Skip to content

Commit fe07cc6

Browse files
committed
fix: update AutoApproveSettings to use useAutoApprovalToggles hook
- Added missing alwaysApproveResubmit to useAutoApprovalToggles hook - Updated AutoApproveSettings to use the shared hook instead of creating its own toggles - Removed unused useMemo import from AutoApproveSettings
1 parent 1ece8e9 commit fe07cc6

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

webview-ui/src/components/settings/AutoApproveSettings.tsx

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { HTMLAttributes, useState, useMemo } from "react"
1+
import { HTMLAttributes, useState } from "react"
22
import { X } from "lucide-react"
33

44
import { useAppTranslation } from "@/i18n/TranslationContext"
@@ -12,6 +12,7 @@ import { Section } from "./Section"
1212
import { AutoApproveToggle } from "./AutoApproveToggle"
1313
import { useExtensionState } from "@/context/ExtensionStateContext"
1414
import { useAutoApprovalState } from "@/hooks/useAutoApprovalState"
15+
import { useAutoApprovalToggles } from "@/hooks/useAutoApprovalToggles"
1516

1617
type AutoApproveSettingsProps = HTMLAttributes<HTMLDivElement> & {
1718
alwaysAllowReadOnly?: boolean
@@ -81,32 +82,7 @@ export const AutoApproveSettings = ({
8182
const [deniedCommandInput, setDeniedCommandInput] = useState("")
8283
const { autoApprovalEnabled, setAutoApprovalEnabled } = useExtensionState()
8384

84-
const toggles = useMemo(
85-
() => ({
86-
alwaysAllowReadOnly,
87-
alwaysAllowWrite,
88-
alwaysAllowExecute,
89-
alwaysAllowBrowser,
90-
alwaysAllowMcp,
91-
alwaysAllowModeSwitch,
92-
alwaysAllowSubtasks,
93-
alwaysApproveResubmit,
94-
alwaysAllowFollowupQuestions,
95-
alwaysAllowUpdateTodoList,
96-
}),
97-
[
98-
alwaysAllowReadOnly,
99-
alwaysAllowWrite,
100-
alwaysAllowExecute,
101-
alwaysAllowBrowser,
102-
alwaysAllowMcp,
103-
alwaysAllowModeSwitch,
104-
alwaysAllowSubtasks,
105-
alwaysApproveResubmit,
106-
alwaysAllowFollowupQuestions,
107-
alwaysAllowUpdateTodoList,
108-
],
109-
)
85+
const toggles = useAutoApprovalToggles()
11086

11187
const { hasEnabledOptions, effectiveAutoApprovalEnabled } = useAutoApprovalState(toggles, autoApprovalEnabled)
11288

webview-ui/src/hooks/useAutoApprovalToggles.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export function useAutoApprovalToggles() {
1414
alwaysAllowMcp,
1515
alwaysAllowModeSwitch,
1616
alwaysAllowSubtasks,
17+
alwaysApproveResubmit,
1718
alwaysAllowFollowupQuestions,
1819
alwaysAllowUpdateTodoList,
1920
} = useExtensionState()
@@ -27,6 +28,7 @@ export function useAutoApprovalToggles() {
2728
alwaysAllowMcp,
2829
alwaysAllowModeSwitch,
2930
alwaysAllowSubtasks,
31+
alwaysApproveResubmit,
3032
alwaysAllowFollowupQuestions,
3133
alwaysAllowUpdateTodoList,
3234
}),
@@ -38,6 +40,7 @@ export function useAutoApprovalToggles() {
3840
alwaysAllowMcp,
3941
alwaysAllowModeSwitch,
4042
alwaysAllowSubtasks,
43+
alwaysApproveResubmit,
4144
alwaysAllowFollowupQuestions,
4245
alwaysAllowUpdateTodoList,
4346
],

0 commit comments

Comments
 (0)