Allowed commands aren't auto-executed

[deathtothenig]

Which API Provider are you using?

Anthropic

Which Model are you using?

Claude 3.5 Sonnet

What happened?

I cannot get chained commands to auto execute. For instance, I cannot get this one to auto execute: npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error". I have tried adding npm test and Select-String, that doesn't work.

Steps to reproduce

1. Add npm test and Select-String to approved commands list
2. Ask Cline to run npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error"
3. It will still require manual approval

Relevant API REQUEST output

No response

Additional context

No response

[mrubens]

@stea9499 we might need to update the list of delimiters - got a sec to take a look?

[deathtothenig]

Fixed it with the update below:

From:

const commands = command.split(/&&|\|\||;|\||\$\(|`/).map(cmd => cmd.trim())

To:

const commands = command.split(/&&|\|\||;|(?<!"[^"]*)\|(?![^"]*")|\$\(|`/).map(cmd => cmd.trim())

[grokpot]

Are changes auto-pushed? because I'm still encountering the error.
Are there plans to use the releases feature of Github?

[mrubens]

Are changes auto-pushed? because I'm still encountering the error. Are there plans to use the releases feature of Github?

Yes these changes should be live in the latest version. Mind sharing the command that isn't working for you?

As for releases, we're still trying to nail down our release process. I assume from your question they would be helpful though?

[jeremy-returned]

I realize this is a totally insecure request, but.... could just get auto-approval for everything? Or maybe just a regex match @mrubens ?

[mrubens]

Hmm I am still able to repro the original issue with npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error"

[smallstepman]

auto approve stopped working for me too, rolling back to 2.2.28 fixed it for me
edit: tho wasn't very consistent either, rolled back to .23, but also keep getting stuck on some commands with &&

I'd also prefer to have an option to allow everything, but have a list of commands which aren't allowed (e.g. rm)

[mrubens]

Thanks @smallstepman, I hear you. Short term this is the fix for the 2.2.29 bug #222

[mrubens]

And #224 should help with the original issue

[mrubens]

Let me know if it’s not fixed!

[smallstepman]

its fantastic, super rock solid! to the point where I think I'm taking back this

I'd also prefer to have an option to allow everything, but have a list of commands which aren't allowed

the idea with command splitting is just perfect