Roo fails to interpret an output of a command run under zsh due to % sign added by the shell to signify the end of output

[pshirshov]

App Version

3.11.3

API Provider

Ollama

Model Used

huihui_ai/qwen2.5-coder-abliterate:14b

Actual vs. Expected Behavior

I've observed that Roo failed to intepret the output of the following command:

❯ git log -1 --pretty=format:"%H %s"
067f0dd45d26a8307c8d7d8277ba9412288fd2c6 release 0.4.5%                                                                                                      

I think it happens due to the % at the end of the output

Detailed Steps to Reproduce

1. Set up zsh as vscode shell
2. Open any git project
3. Ask roo to "check last commit for potential bugs"

Relevant API Request Output

Additional Context

No response

[pshirshov]

This can be fixed by setting PROMPT_EOL_MARK="" before running commands. I guess Roo should do that.

[KJ7LNW]

More info:
https://unix.stackexchange.com/a/302710/431477

This can be fixed by setting PROMPT_EOL_MARK="" before running commands. I guess Roo should do that.

Maybe, but I do not like to mess with people's shell env's if I can avoid it, especially since this is zsh specific and other shells are supported

My opinion is that this is a user setting but if it really is messing up roo maybe we should do it? The problem is that if we hacked that in, someone's going to open another ticket says something like "Roo prevents % symbols!"

@cte @mrubens @hannesrudolph

what are your opinions here?

[pshirshov]

Well, there are two approaches, to prevent % from being printed (which should be fine because the user is not supposed to interact with your shell I think) or to support parsing optional suffixes.

[KJ7LNW]

to prevent % from being printed

this is the one that we want to do, the question is where does the responsibility lie: with the user or with Roo . my opinion is that it is with the user because they are using zsh and should understand its configuration options...but I can see the counter argument as well.

[pshirshov]

Well, zsh is the default macOS shell. I'm not sure though if PROMPT_EOL_MARK is set by default there.

On understanding, most of the zsh users don't even know about that setting. It's obscure and only mentioned once in the middle of a huge man page.

[KJ7LNW]

On understanding, most of the zsh users don't even know about that setting. It's obscure and only mentioned once in the middle of a huge man page.

in that case it is a good idea for Roo to handle it. I have some configuration settings to add for terminal so I will put this on the list as an option for users who wish to enable zsh workarounds.