Completion notification sound plays when reopening already completed tasks

[hannesrudolph]

App Version

3.21.0

API Provider

Anthropic

Model Used

Claude 3.7 Sonnet

🔁 Steps to Reproduce

1. Ensure completion sound effects are enabled in Roo Code settings (Settings → Notifications → Enable sound effects)
2. Start a new task with Roo Code
3. Complete the task successfully (task reaches completion and plays celebration sound)
4. Close or navigate away from the completed task
5. Reopen the same completed task from history

💥 Outcome Summary

Expected: No sound should play when reopening an already completed task
Actual: The completion celebration sound plays again immediately upon opening the completed task

📄 Relevant Logs or Errors

No errors in logs - this is a logic issue where the sound system incorrectly triggers for already completed tasks.

[daniel-lxs]

Scoping this issue further: The problem lies in the resume_completed_task case within ChatView.tsx, which unconditionally triggers the celebration sound upon reopening a task from history.

A more robust solution than tracking played sounds in memory is to prevent this case from playing sounds. The celebration sound should only be played once when the task first emits a completion_result.

Suggested implementation:

1. Remove the playSound("celebration") call from the resume_completed_task case in webview-ui/src/components/chat/ChatView.tsx.
2. To prevent the sound from playing multiple times on the initial completion, one could add a persistent flag to the HistoryItem (e.g., completionSoundPlayed: boolean) and check this flag before playing the sound in the completion_result case.