User feedback lost during tool validation in some tools

[KJ7LNW]

When users provide additional information during tool validation (accept/reject phase) for some tools, this information is completely lost and never enters the discussion history. This creates a frustrating experience where users must repeat information, breaking the natural flow of conversation.

Impact

This inconsistent behavior:

• Disrupts conversation flow when users provide important context
• Forces users to repeat information they have already provided
• Creates a disjointed user experience where feedback seems to be ignored
• Reduces trust in the system ability to maintain conversation context

Affected Components

An AI evaluated that the issue may affect:

• src/core/tools/accessMcpResourceTool.ts
• src/core/tools/codebaseSearchTool.ts
• src/core/tools/fetchInstructionsTool.ts
• src/core/tools/listCodeDefinitionNamesTool.ts
• src/core/tools/listFilesTool.ts
• src/core/tools/searchFilesTool.ts
• src/core/tools/useMcpToolTool.ts

Technical Details

Each tool implementation follows a four-phase lifecycle:

1. Streaming phase (block.partial==true)
2. Model API completion phase (block.partial==false)
3. User validation phase (accept/reject)
4. Tool application phase

The issue occurs in phase 3 (user validation) where user feedback is collected but not properly integrated into the conversation history. Some tools handle this correctly while others do not, creating inconsistent behavior.

Suggested Refactor Approach

Tools should be refactored to standardize the four-phase implementation lifecycle:

genericToolDispatch(
  streaming() => {  ... streaming impl },
  api_complete() => {  ... completion impl },
  user_validation() => { accept/reject from user and integrate feedback},
  apply() => { search_and_replace() the file ...}
)

This approach would ensure consistent handling of user feedback across all tools.

Reproduction Steps

1. Attempt to use the search_and_replace tool that requires user validation
2. When prompted for approval, add additional context or information along with your accept/reject response
3. Observe that your additional information is not reflected in the subsequent conversation history

[exilelabs]

Yes, especially when AI fails to use our tools, the next message sent by the customer will definitely be lost, and the user has no way to always pay attention to whether his tool has failed.

[indiesewell]

The current situation is that even if the file is edited successfully, the bug of losing chat information will occur. v3.21.5

[KJ7LNW]

The current situation is that even if the file is edited successfully, the bug of losing chat information will occur. v3.21.5

Would you please be clear on exactly what you mean by "losing chat information" ? If you mean that the entire chat is lost, then that is a different issue than this one. (losing the entire chat will be solved by #4733 when it merges)

This particular issue specifically addresses the following:

1. Attempt to use the search_and_replace tool that requires user validation
2. When prompted for approval, add additional context or information along with your accept/reject response
3. Observe that your additional information is not reflected in the subsequent conversation history

[indiesewell]

The current situation is that even if the file is edited successfully, the bug of losing chat information will occur. v3.21.5

Would you please be clear on exactly what you mean by "losing chat information" ? If you mean that the entire chat is lost, then that is a different issue than this one. (losing the entire chat will be solved by #4733 when it merges)

This particular issue specifically addresses the following:

1. Attempt to use the search_and_replace tool that requires user validation
2. When prompted for approval, add additional context or information along with your accept/reject response
3. Observe that your additional information is not reflected in the subsequent conversation history

Hi, Has the new version fixed the missing message bug? Why do I feel like the problem is getting worse? Not only will the chat history be lost if the editing fails, but it will also happen if the editing succeeds? I wonder if it has something to do with time, for example, if I wait a while after editing successfully and then send the chat, it will be lost?

Instead of losing the entire chat history, you will lose the single chat history sent by the current user. I have not yet encountered a situation where the entire chat history is lost.

I saw you submitted a patch to fix the problem of losing the entire chat history?