"Approve" or "Reject" buttons clears textarea and does not send text to the chat/model

[sawka]

App Version

v3.23.12

API Provider

Anthropic

Model Used

Claude 3.7 Sonnet

Roo Code Task Links (Optional)

🔁 Steps to Reproduce

So normally when using Roo, when it is applying a diff to a file i get "Save" and "Cancel" buttons. I often write feedback in the textarea about the diff (or tell it how to continue with the task), then when I hit either "Save" or "Cancel" that text gets added to the chat and sent to the model (this is great, and what I'd expect).

But in certain cases... most notably when using the "search_and_replace" tool, i get two buttons "Approve" and "Reject"... if i add text into the textarea then hit either of those buttons the textarea is cleared and the contents do not get added to the chat 😓

---

Here's simple repo steps (just tested with the newest version):

1. Open any source code file (I was using TypeScript, but I don't think the type of code matters).
2. Prompt it with something like:

can you edit @/frontend/appmodel.ts using the search_and_replace tool... to change isDev to isDev2

3. It will then use the search_and_replace tool, and you'll be presented with the two buttons "Approve" and "Reject"
4. Write some text in the textarea, like "great, lets update it again to isDev3".
5. Click either button (tried with both).
6. Notice that the textarea is cleared and what ever you wrote into the textarea is not added to the chat. It isn't just a UI bug as the agent will not follow the new instructions that were typed.

💥 Outcome Summary

Expected the content typed into the textarea before hitting Approve or Reject (when using the search_and_replace tool) would be added to the chat and sent to the model.

📄 Relevant Logs or Errors (Optional)

[roomote]

I am working on fixing this issue. The problem is that when using the search_and_replace tool, the "Approve" and "Reject" buttons clear the textarea content instead of sending it to the chat like the "Save" and "Cancel" buttons do with other tools. I will investigate the webview UI code to identify and fix this inconsistency.

[dosubot]

Hi @sawka! I'm Dosu and I’m helping the Roo-Code team.

I couldn't find any documentation or release notes that explain how the 'Approve' and 'Reject' buttons in the 'search_and_replace' tool should handle textarea input, or why this behavior differs from the 'Save'/'Cancel' flow. There are also no known issues or troubleshooting steps about this in the docs or changelogs I checked. Based on what’s available, this looks like an inconsistency or possibly a bug, since other flows do send textarea input to the chat/model as expected docs release notes. If you want, I can help draft a detailed report or suggest possible workarounds. Let me know how you’d like to proceed!

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}   

[roomote]

I am working on fixing this issue. The problem is that when using the search_and_replace tool, the "Approve" and "Reject" buttons clear the textarea content instead of sending it to the chat like the "Save" and "Cancel" buttons do with other tools. I will investigate the webview UI code to identify and fix this inconsistency.

[daniel-lxs]

The PR doesn't completely solve the issue.

While PR #5757 correctly adds searchAndReplace to use "Save"/"Cancel" buttons instead of "Approve"/"Reject", it only addresses the button labeling problem. The core issue - that clicking these buttons clears the textarea without sending the user's feedback to the chat/model - remains unresolved.

To properly solve this we should:

1. Verify that handlePrimaryButtonClick and handleSecondaryButtonClick are correctly processing the searchAndReplace tool responses
2. Check if there's a different code path or condition that prevents the textarea content from being sent when using this specific tool
3. Ensure the backend properly handles the searchAndReplace tool's response with user feedback
4. Add test coverage to prevent regression of this user feedback flow

The current fix is incomplete because it only changes the UI labels without addressing the underlying functionality issue where user feedback is lost.