Bug: Command validation crashes when parsing BASH_REMATCH in gh alias

[KJ7LNW]

Version: 3.23.14
API Provider: OpenRouter
Model: claude-3-7-sonnet

What happened?

Running a specific gh alias set command with Claude 4 on OpenRouter causes the application to crash with the following error:

chunk-FNONPZGU.js?v=431cafd5:16718 Uncaught Error: Bad substitution: BASH_REM
    at parseCommand (command-validation.ts:109:17)
    at getCommandDecision (command-validation.ts:393:22)
    at ChatView.tsx:927:11
    at ChatView.tsx:935:11
    at ChatView.tsx:996:34

The error occurs in the command validation system when trying to parse BASH-specific syntax like BASH_REMATCH.

Expected behavior

The command validation should either properly handle BASH-specific syntax or gracefully fail without crashing the application.

Steps to reproduce

1. Use Claude 4 on OpenRouter
2. Tell roo, run exactly the following command:

gh alias set pr-reviews --clobber '!f() { 
  url="$1"
  if [[ "$url" =~ github\.com/([^/]+/[^/]+)/pull/([0-9]+) ]]; then
    repo="${BASH_REMATCH[1]}"
    pr="${BASH_REMATCH[2]}"
    echo "=== Review Comments for $repo PR #$pr ==="
    gh api "repos/$repo/pulls/$pr/reviews" --jq ".[] | {user: .user.login, state: .state, body: .body, submitted_at: .submitted_at}"
    echo
    echo "=== Line Comments ==="
    gh api "repos/$repo/pulls/$pr/comments" --jq ".[] | {user: .user.login, body: .body, path: .path, line: .line, created_at: .created_at}"
  else
    echo "Error: Please provide a valid GitHub PR URL"
    echo "Example: gh pr-reviews https://github.com/owner/repo/pull/123"
    echo "Received: $url"
  fi
}; f'

Additional context

The issue appears to be in the parseCommand function in command-validation.ts which fails to properly handle BASH-specific syntax patterns like BASH_REMATCH.

The command validation system attempts to parse shell commands to determine if they should be allowed, but it doesn't properly handle all shell syntax constructs, particularly those specific to BASH like array indexing with BASH_REMATCH[n].

This crash prevents users from creating useful GitHub CLI aliases that use BASH features.

[roomote]

I am working on fixing this issue. The problem appears to be in the command validation system not properly handling BASH-specific syntax like BASH_REMATCH array indexing. I will investigate the parseCommand function in command-validation.ts and implement a fix to handle these shell constructs gracefully.

[roomote]

I have successfully fixed the issue and created a pull request: #5979

The fix adds specific handling for BASH_REMATCH array syntax in the parseCommand function to prevent the shell-quote library from throwing "Bad substitution" errors. The solution handles both ${BASH_REMATCH[n]} and $BASH_REMATCH[n] patterns by temporarily replacing them during parsing.

All tests are passing and CI checks have completed successfully. The PR is ready for review.

[KJ7LNW]

here is another case:

find . -name "*.js" -not -path "*/node_modules/*" | while read jsfile; do
  basename=${jsfile%.js}
  if [ -f "${basename}.ts" ] || [ -f "${basename}.tsx" ]; then
    echo "Removing $jsfile (has ${basename}.ts or ${basename}.tsx)"
    rm -f "$jsfile" "${jsfile}.map" "${basename}.d.ts.map"
  else
    echo "Keeping $jsfile (no corresponding .ts/.tsx)"
  fi
done