getStorageBasePath(), race condition

[jimweller]

App Version

3.25.17

API Provider

AWS Bedrock

Model Used

N/A

Roo Code Task Links (Optional)

N/A

🔁 Steps to Reproduce

set roo-cline.customStoragePath in vscode settings.json

open vscode

select roo code

💥 Outcome Summary

Intermittent popups with error

Custom storage path "/Users/jimweller/.roo/" is unusable, will use default path

📄 Relevant Logs or Errors (Optional)

I believe there is a race condition with getStorageBasePath() where multiple instances are running simultaneously. So, the .write_test file may or may not be present. Recommend adding a unqiue suffix to the .write_test file to prevent conncurrent calls of getStorageBasePath() from conflicting on the file.

Creating a PR

[roomote]

I'm here to help out the maintainers and am going to see if I can fix this race condition issue with getStorageBasePath(). I'll investigate the concurrent access to the .write_test file and implement a solution using unique suffixes as suggested. Working on it now!

[roomote]

✅ I've successfully fixed the race condition issue in getStorageBasePath()!

Solution implemented:

• Added a unique suffix to the .write_test file using process ID, timestamp, and random string
• This prevents concurrent instances from conflicting when checking write permissions
• Added comprehensive test coverage including a specific test for concurrent calls

Pull Request: #7175

All CI checks have passed successfully. The fix ensures that each concurrent call to getStorageBasePath() uses its own unique test file, eliminating the race condition that was causing the intermittent "Custom storage path is unusable" errors.

Thanks for reporting this issue!