Skip to content

File scroll to edit location after "User Edits" in diff. #7996

@j-east

Description

@j-east

What specific problem does this solve?

The issue that I have a potential fix for occurs when you make an edit in the diff view before approving a file change by Roo Code. What this does it if you make an manual edits after you approve the changes the file will scroll to the location of the edits. It makes adding additional changes/adding logs much less work.

Additional context (optional)

No response

Roo Code Task Links (Optional)

No response

Request checklist

  • I've searched existing Issues and Discussions for duplicates
  • This describes a specific problem with clear impact and context

Interested in implementing this?

  • Yes, I'd like to help implement this feature

Implementation requirements

  • I understand this needs approval before implementation begins

How should this be solved? (REQUIRED if contributing, optional otherwise)

In Roo Code there is a section that detects if there were user edits made to the diff. I added a call to check the diff for the line number of the first user edit and then focus that file (after the diff view is closed) and set the scroll so that the edit is in view.

How will we know it works? (Acceptance Criteria - REQUIRED if contributing, optional otherwise)

You can make a user edit in the diff (add a new line or a comment) and then approve the change. You will see the file open and the comment you just added visible in the editor.

Technical considerations (REQUIRED if contributing, optional otherwise)

There is adequate error handling with some minimal logging that shouldn't be an issue.

Trade-offs and risks (REQUIRED if contributing, optional otherwise)

Minimal. Some slight user inconvenience if they didn't want the file open after making edits but it feels like expected behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.enhancementNew feature or requestproposal

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions