[BUG] Messages queued during context condensing don't get sent when context condensing is done.

[JosXa]

Problem (one or two sentences)

Messages queued during context condensing don't get sent when context condensing is done. They remain queued.

Context (who is affected and when)

Everyone as far as I can tell

Reproduction steps

1. Have large conversation
2. Condense context
3. While it's working on condensing, enqueue a message

Expected result

Once condensing is done, it sends the message

Actual result

Message remains queued. Also, when clicking "New Task", that queued message also remains and cannot be cleared.

Variations tried (optional)

No response

App Version

v3.28.14

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote]

I'm exploring a potential fix for this issue where messages queued during context condensing aren't being sent after condensing completes. I'll open a PR to share progress.

[roomote]

I've opened PR #8478 with a fix for this issue: #8478

The fix adds a call to processQueuedMessages() after the context condensing operation completes, ensuring that any messages queued during condensing are properly sent.

Note: There's currently one integration test failing that appears to be unrelated to this change (a timeout in an apply_diff test). The fix itself is straightforward and all other tests are passing.

[hannesrudolph]

@roomote there are two linked PRs to this issue, which one makes more sense?

[roomote]

I've seen your comment and will analyze both PRs to determine which approach makes more sense. I'll explore the implementation details and provide a recommendation.

[roomote]

@hannesrudolph After analyzing both PRs, I recommend PR #8478 as the better solution.

Analysis

Both PRs fix the same issue but at different levels:

PR #8478 (Created Oct 2):

• Fixes the issue in Task.condenseContext() method
• Adds this.processQueuedMessages() directly after condensing completes
• Location: src/core/task/Task.ts line 1054

PR #8528 (Created Oct 6):

• Fixes the issue in ClineProvider.condenseTaskContext() method
• Adds task.processQueuedMessages() after calling task.condenseContext()
• Location: src/core/webview/ClineProvider.ts line 1541

Why PR #8478 is better:

1. Fixes at the source: The fix is placed in the Task class where context condensing actually happens, ensuring queued messages are processed regardless of how condenseContext() is called.

2. More comprehensive coverage: PR fix: process queued messages after context condensation #8528 only fixes the manual trigger case through ClineProvider. If condenseContext() is ever called directly on a Task instance or from other code paths, PR fix: process queued messages after context condensation #8528 wouldn't help.

3. Better encapsulation: The Task class manages its own message queue, so it should be responsible for processing queued messages after its own operations complete.

4. Future-proof: If context condensing is triggered from new code paths in the future, PR fix: process queued messages after context condensing completes #8478 ensures the fix still works.

Both PRs include good test coverage, but PR #8478's approach of fixing the issue at its root cause makes it the more robust solution.