forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.Someone is actively working on this. Should link to a PR soon.bugSomething isn't workingSomething isn't working
Description
Problem (one or two sentences)
Issue summary
A previous issue I opened #8660 created #8663 which specified the defaultUserAgentProvider in the bedrock request. Rather than appending a custom user agent, it replaced it altogether which causes those using bedrock to lack other contextual user agent information like operating system.
This was not a total mistake at the time because the AWS SDK had a separate aws/aws-sdk-js-v3#7439 issue that didn't enable the userAgentAppId: field to be correctly propagated.
Ask
- Upgrade @AWS-SDK dependencies to include fix(nested-clients): propagate clientConfig to inner STS client in role assumption aws/aws-sdk-js-v3#7445. Minimum version required should be 3.914.0, but latest is also okay.
- Update bedrock.ts to use
userAgentAppIdrather thandefaultUserAgentProviderwhich will append the RooCode userAgent rather than replace it.
Context (who is affected and when)
Bedrock users.
Reproduction steps
- Send request with RooCode
- Check Cloudwatch CloudTrail logs and confirm is only
app/RooCode#3.30.0 m/E,e
Expected result
aws-sdk-js/3.922.0 ua/2.1 os/darwin#24.6.0 lang/js md/nodejs#22.19.0 api/bedrock-runtime#3.922.0 m/E,e app/RooCode#3.30.0
Actual result
RooCode/3.30.0 m/E,e
Variations tried (optional)
No response
App Version
3.30.0
API Provider (optional)
AWS Bedrock
Model Used (optional)
N/A
Roo Code Task Links (optional)
No response
Relevant logs or errors (optional)
Metadata
Metadata
Assignees
Labels
Issue - In ProgressSomeone is actively working on this. Should link to a PR soon.Someone is actively working on this. Should link to a PR soon.bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done