fix: use JavaScript-based hover for checkpoint menu visibility #10056
+62
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace CSS group-hover with onMouseEnter/onMouseLeave handlers to fix checkpoint restore button not displaying on Rocky Linux and some Windows configurations where CSS :hover doesn't trigger reliably. Fixes #8344
dosubot
bot
added
size:M
Contributor
Review completed. No issues were found with the current changes; the PR looks ready to merge.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
daniel-lxs
approved these changes
Dec 12, 2025
cte
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8344
Fixes the checkpoint restore button not displaying on hover on Rocky Linux and some Windows configurations.
Problem
PR #7985 changed the checkpoint menu to be hidden by default and only visible on hover using Tailwind's
group-hover:blockCSS class. However, this CSS-based hover approach doesn't work reliably on all platforms, creating a chicken-and-egg problem where users can never see the checkpoint buttons to click them.Solution
Replaced CSS-based hover (
group-hover:block) with JavaScript-based hover usingonMouseEnter/onMouseLeavehandlers withuseState. This approach:MermaidButton.tsx,ImageViewer.tsx, andMarkdown.tsxChanges
isHoveringstate and mouse event handlers toCheckpointSaved.tsxmenuVisible = isHovering || isPopoverOpen || isClosinggroup-hover:blockclass dependencyTesting
Fixes #8344