Skip to content

Conversation

@jakenuts
Copy link

Description

Updated the language of the rule that prevented Roo from seeing the terminal output when using the latest Claude Sonnet 3.5 model.

Instead of:

When executing commands, if you don't see the expected output, assume the terminal executed the command successfully and proceed with the task. The user's terminal may be unable to stream the output back properly. If you absolutely need to see the actual terminal output, use the ask_followup_question tool to request the user to copy and paste it back to you.

It now reads:

  • When executing commands, if you don't see any output, the user's terminal may be unable to stream the output back properly. Use the ask_followup_question tool to request the user to copy and paste it back to you.

Type of change

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I loaded the history of a task where Roo was ignoring the terminal output (or rather "could not see" the output) and with this change to the associated rule Roo started seeing the errors and correcting them.

Checklist:

  • [X ] My code follows the patterns of this project
  • I have performed a self-review of my own code
  • [O] I have commented my code, particularly in hard-to-understand areas
  • [O] I have made corresponding changes to the documentation

Additional context

Related Issues

#1038

Reviewers

@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@KJ7LNW
Copy link
Contributor

KJ7LNW commented Mar 7, 2025

this maybe an important clarification because unix philosophy has always been to exclude output for successful operations. I think this philosophy is less common these days, but still a consideration:

  • When executing commands: if you don't see any output AND output is expected, the user's terminal may be unable to stream the output back properly. Use the ask_followup_question tool to request the user to copy and paste it back to you.

@KJ7LNW
Copy link
Contributor

KJ7LNW commented Mar 7, 2025

also in the less common case of a user not supporting shell integration, #1365 will report this message to the model:

		this.emit(
				"completed",
				"<shell integration is not available, so terminal output and command execution status is unknown>",
			)

@mrubens mrubens moved this from PR [Unverified] to PR [Deferred] in Roo Code Roadmap Mar 10, 2025
@hannesrudolph hannesrudolph moved this from PR [Deferred] to PR [Draft/WIP] in Roo Code Roadmap May 10, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Draft/WIP] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Draft / In Progress] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

Hey @jakenuts,
Thank you for your PR, We noticed this PR is stale and will be closed. If you plan to revisit this, please create an issue first as required by our issue-first approach before opening a new PR.

@daniel-lxs daniel-lxs closed this May 26, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft/WIP] to Done in Roo Code Roadmap May 26, 2025
@github-project-automation github-project-automation bot moved this from TEMP to Done in Roo Code Roadmap May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants