Fix: Custom temperature cannot be unchecked

[System233]

Context

Fix #1402

Since the backend uses incremental saving, and undefined in modelTemperature will not be serialized, this field is not updated.

Implementation

Screenshots

before	after

How to Test

First set a value for modelTemperature and save it, then uncheck it and save it again

Get in Touch

---

Important

Fixes issue with unchecking custom temperature by allowing null values for modelTemperature and updating TemperatureControl component.

• Behavior:
  • Fixes issue where custom temperature could not be unchecked by allowing modelTemperature to be null in api.ts.
  • Updates TemperatureControl in TemperatureControl.tsx to handle null values for unsetting temperature.
• Code Changes:
  • Changes modelTemperature type to number | null in ApiHandlerOptions in api.ts.
  • Updates TemperatureControl component to use null instead of undefined for unsetting temperature.

^{This description was created by for baa9b97a19cc336b6c39cbf00ff231ecfe41c589. It will automatically update as commits are pushed.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9ceccde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mrubens]

Thank you!

[mrubens]

Hi, I noticed that in the latest version of the app there are issues with temperature control settings. Specifically, if you load a profile that has a custom temp and then switch to one that doesn’t, the second one will appear to have the same custom temp as the first. I think more likely related to the new context proxy stuff than to this specific change, but maybe related to the point about undefined being unserializable or something?

cc: @samhvw8 in case you have any ideas

[samhvw8]

@mrubens let me recheck this issues

[System233]

I think configuration updates should be atomic (such as using an object), rather than storing each field individually.