Skip to content

Conversation

@shaybc
Copy link
Contributor

@shaybc shaybc commented Mar 8, 2025

Context

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Converted telemetry methods to asynchronous and updated references to use await in TelemetryService.ts, Cline.ts, and ClineProvider.ts.

  • Telemetry Methods:
    • Changed telemetry methods in TelemetryService.ts to be asynchronous, including capture(), captureEvent(), captureTaskCreated(), captureTaskRestarted(), captureTaskCompleted(), captureConversationMessage(), captureModeSwitch(), and captureToolUsage().
  • Usage Updates:
    • Updated references to telemetry methods to use await in Cline.ts for methods like captureToolUsage(), captureTaskCompleted(), and captureConversationMessage().
    • Updated captureModeSwitch() in ClineProvider.ts to use await.

This description was created by Ellipsis for 2004cca. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2025

⚠️ No Changeset found

Latest commit: 2004cca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 8, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 8, 2025

I don't think the telemetry should need to be blocking - seems like there's something else going on here

@shaybc
Copy link
Contributor Author

shaybc commented Mar 8, 2025

I don't think the telemetry should need to be blocking - seems like there's something else going on here

i agree - i made a mistake, the solution is correct but it is not necessary, the problem i originally encountered was in the sub-tasks PR that did not cover a case of a command being ran in the end of a task, for some reason, after disabling the telemetry the ai decided for un-related reason to not execute a cmd - and that fixed the behavior not the disablement of the telemetry,

after doing some testing i found the solution to disable the telemetry (or making it sync) is not consistent, i have undo my changes and fixed the sub-tasks bug,

i am closing this PR and i will promote the next sub-tasks bug fix along with the user approval UI

@shaybc
Copy link
Contributor Author

shaybc commented Mar 8, 2025

no need to convert telemetry calls to sync (awaited on async), telemetry calls should not come on the expense of the users

@shaybc shaybc closed this Mar 8, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 8, 2025
@mrubens
Copy link
Collaborator

mrubens commented Mar 8, 2025

Thank you for digging in!

@shaybc shaybc deleted the sbc_fix_telemetry_async branch March 13, 2025 18:54
ipattis pushed a commit to ipattis/roo-code that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants