Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 9, 2025

Context

  • Add a Tab component to standardize the root layout of each tab view.
  • Add roo-portal div and use it in our @shadcn/ui components that require a portal.

Before:
Screenshot 2025-03-09 at 2 47 59 PM

After:
Screenshot 2025-03-09 at 2 47 43 PM

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Introduce Tab component for standardized layout and roo-portal for consistent portal rendering across views.

  • Components:
    • Introduce Tab, TabHeader, and TabContent components in Tab.tsx for consistent layout across views.
    • Add Alert component in Alert.tsx for displaying alert messages.
    • Implement useRooPortal hook in useRooPortal.ts for consistent portal rendering.
  • Layout Changes:
    • Refactor HistoryView.tsx, McpView.tsx, PromptsView.tsx, SettingsView.tsx, and WelcomeView.tsx to use Tab components for layout.
    • Replace chat-view-portal with roo-portal in ChatView.tsx and CheckpointMenu.tsx.
  • Miscellaneous:
    • Remove unused import in CheckpointMenu.tsx.
    • Update dropdown-menu.tsx, popover.tsx, and select-dropdown.tsx to use useRooPortal for portal container.
    • Minor CSS adjustments in index.css for consistent styling.

This description was created by Ellipsis for 9fdc546. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner March 9, 2025 22:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Mar 9, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 9, 2025

Thank you for your contributions! After reviewing the pull request, it seems that the changes are primarily focused on layout fixes and component updates across various files. While the number of files changed is significant, the changes appear to be related and cohesive, focusing on improving the UI structure and component functionality.

However, if you believe there are distinct groups of changes that could be logically separated for better clarity and reviewability, please consider splitting the pull request into smaller ones. This can help streamline the review process and ensure each set of changes is thoroughly evaluated.

If you need any assistance or have questions about how to split the changes, feel free to reach out!

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 9, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap Mar 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 9fdc546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cte cte changed the title Cte/layout fixes @cte App tab layout fixes Mar 10, 2025
@cte cte changed the title @cte App tab layout fixes App tab layout fixes Mar 10, 2025
@cte cte merged commit 0b2abee into main Mar 10, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap Mar 10, 2025
@cte cte deleted the cte/layout-fixes branch March 10, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants