Skip to content

Simplify npm install by automatically installing npm-run-all #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cte merged 2 commits into from
Mar 11, 2025
Merged

Simplify npm install by automatically installing npm-run-all #1548

cte merged 2 commits into from
Mar 11, 2025

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 10, 2025 •
edited by ellipsis-dev bot
Loading

Context

This got me a few times when preparing the Docker container for our benchmarks. Slight DX improvement.

Implementation

Screenshots

before after

How to Test

Get in Touch

Important

Simplifies npm install by automatically installing npm-run-all and updates related workflows and documentation.

  • Behavior:
    • Simplifies npm install by ensuring npm-run-all is installed automatically in install:all script in package.json.
    • Updates install:ci to use install:all in package.json.
  • Workflows:
    • Replaces npm run install:ci with npm run install:all in changeset-release.yml, code-qa.yml, and marketplace-publish.yml.
  • Documentation:
    • Updates README.md to reflect changes in installation instructions, removing install:ci fallback.

This description was created by Ellipsis for 2187369. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner March 10, 2025 18:37
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2187369

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 10, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap Mar 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@cte cte merged commit 33f232a into main Mar 11, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap Mar 11, 2025
@cte cte deleted the cte/npm-install-all branch March 11, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cte @mrubens