Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Mar 13, 2025

Context

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Refactor task and subtask handling in e2e tests and core logic, introducing new functions and events for improved task management and synchronization.

  • Behavior:
    • Refactor task handling in modes.test.ts and subtasks.test.ts to improve task switching and subtask management.
    • Introduce clearCurrentTask() in api.ts to handle task completion and resumption.
    • Update Cline class in Cline.ts to include instanceId for better task tracking.
  • Functions:
    • Add waitForCompletion() and waitUntilAborted() in utils.ts for improved test synchronization.
    • Modify abortTask() in Cline.ts to log task abortion and handle task state more robustly.
  • Events:
    • Add new events taskStarted, taskPaused, taskUnpaused, and taskAborted in roo-code.d.ts and api.ts for better task lifecycle management.
  • Misc:
    • Update ClineProvider in ClineProvider.ts to manage task stack more effectively.
    • Minor logging improvements in Cline.ts and ClineProvider.ts.

This description was created by Ellipsis for c609856. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

⚠️ No Changeset found

Latest commit: c609856

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 13, 2025
console.log(`[subtasks] finishing subtask ${lastMessage}`)
// remove the last cline instance from the stack (this is the finished sub task)
await this.removeClineFromStack()
// resume the last cline instance in the stack (if it exists - this is the 'parnt' calling task)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: The comment says "parnt calling task". It should be "parent calling task".

Suggested change
// resume the last cline instance in the stack (if it exists - this is the 'parnt' calling task)
// resume the last cline instance in the stack (if it exists - this is the 'parent' calling task)

@cte cte merged commit de85cc5 into main Mar 13, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 13, 2025
@cte cte deleted the cte/fix-e2e branch March 13, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants