-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Show menu buttons in tab view #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
a3760d9 to
98f8546
Compare
| const getCommandsMap = ({ context, outputChannel, provider }: RegisterCommandOptions) => { | ||
| return { | ||
| "roo-cline.activationCompleted": () => {}, | ||
| "roo-cline.plusButtonClicked": async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding try/catch blocks in these asynchronous command callbacks (e.g., in roo-cline.plusButtonClicked) to gracefully handle errors arising from provider methods. This will prevent unhandled promise rejections and improve overall extension stability.
Based on cline/cline#2511 - thank you @benny123tw for figuring this out!
Important
Adds menu buttons to tab view and tests for visible provider handling in
registerCommands.ts.editor/titleinpackage.jsonfor tab view with commands likeplusButtonClicked,promptsButtonClicked, etc.getVisibleProviderOrLoginregisterCommands.tsto ensure commands operate on the visible provider.registerCommands.test.tsto testgetVisibleProviderOrLogfunction, ensuring it returns the visible provider or logs an error if none is found.getVisibleProviderOrLoginregisterCommands.tsto fetch visibleClineProvideror log an error.This description was created by
for 98f8546. It will automatically update as commits are pushed.