Skip to content

Better logic for choosing the view column when opening Roo in a tab #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Apr 4, 2025
Merged

Better logic for choosing the view column when opening Roo in a tab #2282

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc4968
Better logic for choosing the view column when opening Roo in a tab
mrubens Apr 4, 2025
2cd4a28
PR feedback
mrubens Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/activate/registerCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,18 +123,26 @@ export const openClineInNewTab = async ({ context, outputChannel }: Omit<Registe
// don't need to use that event).
// https://github.com/microsoft/vscode-extension-samples/blob/main/webview-sample/src/extension.ts
const tabProvider = new ClineProvider(context, outputChannel, "editor")
const lastCol = Math.max(...vscode.window.visibleTextEditors.map((editor) => editor.viewColumn || 0))

// Check if there are any visible text editors, otherwise open a new group
// to the right.
const activeEditor = vscode.window.activeTextEditor
const hasVisibleEditors = vscode.window.visibleTextEditors.length > 0

let targetCol: vscode.ViewColumn

if (!hasVisibleEditors) {
// No editors open, open in first column
targetCol = vscode.ViewColumn.One
} else if (activeEditor && activeEditor.document.fileName === "" && vscode.window.visibleTextEditors.length === 1) {
// Only one editor and it's empty (untitled), reuse it
targetCol = activeEditor.viewColumn ?? vscode.ViewColumn.One
} else {
// Otherwise, create a new group to the right
await vscode.commands.executeCommand("workbench.action.newGroupRight")
// New group becomes the last + 1
const lastCol = Math.max(...vscode.window.visibleTextEditors.map((e) => e.viewColumn || 1))
targetCol = (lastCol + 1) as vscode.ViewColumn
}

const targetCol = hasVisibleEditors ? Math.max(lastCol + 1, 1) : vscode.ViewColumn.Two

const newPanel = vscode.window.createWebviewPanel(ClineProvider.tabPanelId, "Roo Code", targetCol, {
enableScripts: true,
retainContextWhenHidden: true,
Expand Down
Loading