feat: Add a way to limit the number of results from search_files tool #2294
Conversation
Currently search_files will produce up to 300 results (an arbitrary number). In cortain cases this is too large number because only first few occurrences are wanted. Unfortunately if too generic search pattern is selected, lots of results will be returned to the LLM and this will reduce remaining context significantly and require more time to process than needed. To address this, an explicit optional max_results parameter has been added to the search_files tool. Its explanation is simple and it does not increase the Roo Code prompt size too much. If the max_results parameter is not supplied, code works exactly as before.
|
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Instead of having the LLM choose this, I think it might be more consistent to make this a setting in the Context Management section of the settings screen.
|
Hey @p12tic, |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
3 participants
Context
Currently search_files will produce up to 300 results (an arbitrary number). In cortain cases this is too large number because only first few occurrences are wanted. Unfortunately if too generic search pattern is selected, lots of results will be returned to the LLM and this will reduce remaining context significantly and require more time to process than would be otherwise necessary.
Implementation
To address this, an explicit optional max_results parameter has been added to the search_files tool. Its explanation is simple and it does not increase the Roo Code prompt size too much.
If the max_results parameter is not supplied, code works exactly as before.
Screenshots
Not applicable.
How to Test
Unfortunately there are no existing unit or integration tests for this functionality. The change has been tested manually.