Skip to content

Conversation

@kyle-apex
Copy link
Contributor

@kyle-apex kyle-apex commented Apr 5, 2025

Context

Everyone's been clamoring for the buttons in the header of the Settings tab to be the same size as the buttons on the other tabs.

Implementation

I updated buttons to use @components/ui as specified in #1433 .

Screenshots

Before: 🤮
image
After: Very standardized, very demure
image

How to Test

Review behavior of all buttons on History/MCP/Settings/Prompt view for click and title behavior


Important

Standardized button components across views by replacing VSCodeButton with Button from @/components/ui/button.

  • Button Standardization:
    • Replaced VSCodeButton with Button from @/components/ui/button in HistoryView.tsx, McpView.tsx, PromptsView.tsx, and SettingsView.tsx.
    • Updated button properties to align with the new Button component API, such as variant and size.
  • Behavior:
    • Ensures consistent button appearance and behavior across different views.
    • Adjusted button titles and click handlers to maintain existing functionality.
  • Misc:
    • Removed unused imports related to VSCodeButton in affected files.

This description was created by Ellipsis for 769bf2f. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 769bf2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 5, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 5, 2025
@mrubens mrubens merged commit 6ece39e into RooCodeInc:main Apr 5, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants