Skip to content

Conversation

@shtse8
Copy link
Contributor

@shtse8 shtse8 commented Apr 5, 2025

This PR addresses issue #598 by preventing the chat view from automatically scrolling to the bottom when a user collapses a chat row after they have manually scrolled up. The autoscroll behavior is only re-enabled when the user scrolls back to the bottom.


Important

Fixes autoscroll issue in ChatView by disabling it when collapsing rows after manual scroll, re-enabling only when scrolled to bottom.

  • Behavior:
    • In ChatView, disables autoscroll when collapsing rows after manual scroll up.
    • Autoscroll re-enabled only when user scrolls back to bottom.
  • Code Changes:
    • Modifies toggleRowExpansion function to check disableAutoScrollRef before autoscrolling.
    • Updates conditions for autoscroll in toggleRowExpansion to prevent unwanted scrolling.

This description was created by Ellipsis for 0131ed497c8d6ed8a2f74d343ab27365bce4a894. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 8fe70e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 5, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 5, 2025

Thanks for the PR! This still seems to automatically scroll me down all the time though - is there a specific case that this fixes?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 5, 2025
@shtse8 shtse8 closed this Apr 5, 2025
@shtse8 shtse8 force-pushed the feature/598-disable-autoscroll branch from 8e4b280 to 8fe70e3 Compare April 5, 2025 22:53
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 5, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 5, 2025
@shtse8
Copy link
Contributor Author

shtse8 commented Apr 5, 2025

Hi @mrubens, you were right. My previous attempt in this PR didn't fully address the autoscroll issue. I underestimated the complexity.

After further investigation, I believe I have a better understanding of the root cause now. I've implemented a revised solution in a new Pull Request: #2334.

Thanks for pointing out the issue!

@mrubens
Copy link
Collaborator

mrubens commented Apr 5, 2025

Thank you! Will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants