fix: persist settings on api.setConfiguration #2341
Conversation
Values weren't being saved to the settings store, preventing switching to newly created profiles.
|
dosubot
bot
added
the
size:XS
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| public async setConfiguration(values: RooCodeSettings) { | ||
| await this.sidebarProvider.setValues(values) | ||
| await this.sidebarProvider.providerSettingsManager.saveConfig(values.currentApiConfigName || "default", values) |
There was a problem hiding this comment.
Consider adding error handling around the call to saveConfig. If persisting the configuration fails, it could interrupt subsequent UI updates. Wrapping this call in try/catch (or ensuring errors are caught upstream) will improve robustness.
…imation …" (RooCodeInc#2341) This reverts commit 12f16a4.
3 participants
Context
Values weren't being saved to the settings store, preventing switching to newly created profiles. See this Discord thread for screenshots and source code.
Implementation
See diff. Explicitly call
saveConfigafter changing configurations. I'm not sure that I love taking the name fromcurrentApiConfigNamebut we'd need to rework the API quite a bit to allow for an explicitnameparam.How to Test
Create a custom extension that calls these APIs and do something like this:
Important
In
api.ts,setConfigurationnow persists settings by callingsaveConfigwithcurrentApiConfigNameor "default".api.ts,setConfigurationnow callssaveConfigto persist settings usingcurrentApiConfigNameor "default" if not provided.This description was created by
for 7d2365c. It will automatically update as commits are pushed.