Skip to content

fix: persist settings on api.setConfiguration #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cte merged 1 commit into from
Apr 6, 2025
Merged

fix: persist settings on api.setConfiguration #2341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/exports/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export class API extends EventEmitter<RooCodeEvents> implements RooCodeAPI {

public async setConfiguration(values: RooCodeSettings) {
await this.sidebarProvider.setValues(values)
await this.sidebarProvider.providerSettingsManager.saveConfig(values.currentApiConfigName || "default", values)
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling around the call to saveConfig. If persisting the configuration fails, it could interrupt subsequent UI updates. Wrapping this call in try/catch (or ensuring errors are caught upstream) will improve robustness.

await this.sidebarProvider.postStateToWebview()
}

Expand Down