Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Apr 6, 2025

Important

Adds deep linking to settings sections, allowing direct navigation to specific sections within the SettingsView.

  • Behavior:
    • Adds deep linking to SettingsView by introducing targetSection prop in App.tsx and SettingsView.tsx.
    • Updates onMessage handler in App.tsx to set currentSection based on message values.
    • Modifies handleOpenSettings in AutoApproveMenu.tsx, ChatTextArea.tsx, ChatView.tsx, and TelemetryBanner.tsx to include section in message values.
  • Components:
    • Updates SettingsView to scroll to targetSection on render using useEffect.
    • Passes targetSection prop to SettingsView in App.tsx.
  • Translations:
    • Adds initializingWarning translation for checkpoint initialization in multiple language files.

This description was created by Ellipsis for 060ef74. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: 060ef74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 6, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Apr 6, 2025

The pull request includes changes that could be split into smaller, more focused pull requests. Specifically, the translation updates for checkpoint warnings in multiple languages could be separated from the functionality changes related to adding deep links to settings sections. This would help in reviewing and managing the changes more effectively. Please consider splitting the translation updates into a separate pull request.

"checkpoint": {
"initial": "初始检查点",
"regular": "检查点",
"initializingWarning": "正在初始化检查点...如果耗时过长,你可以在<settingsLink>设置</settingsLink>中禁用检查点并重新启动任务。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly-added string for "initializingWarning" currently reads:

"正在初始化检查点...如果耗时过长,你可以在设置中禁用检查点并重新启动任务."

For better typographical consistency with the rest of the file, consider using Chinese ellipsis "……" and a Chinese full-stop "。" instead of the English versions "..." and ".".

Suggested change
"initializingWarning": "正在初始化检查点...如果耗时过长,你可以在<settingsLink>设置</settingsLink>中禁用检查点并重新启动任务。",
"initializingWarning": "正在初始化检查点……如果耗时过长,你可以在<settingsLink>设置</settingsLink>中禁用检查点并重新启动任务。"

@mrubens mrubens merged commit 393688c into main Apr 6, 2025
19 checks passed
@mrubens mrubens deleted the settings_deep_links branch April 6, 2025 18:31
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants