From cd87956ee5f870f00e233c6c5fe68f16858b912a Mon Sep 17 00:00:00 2001 From: elianiva <51877647+elianiva@users.noreply.github.com> Date: Fri, 18 Apr 2025 14:55:57 +0700 Subject: [PATCH 1/3] fix(chat): better loading feedback --- webview-ui/src/components/common/CodeAccordian.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/webview-ui/src/components/common/CodeAccordian.tsx b/webview-ui/src/components/common/CodeAccordian.tsx index 468eade72f..3673135674 100644 --- a/webview-ui/src/components/common/CodeAccordian.tsx +++ b/webview-ui/src/components/common/CodeAccordian.tsx @@ -67,7 +67,13 @@ const CodeAccordian = ({ MozUserSelect: "none", msUserSelect: "none", }} + className={`${isLoading ? "animate-pulse" : ""}`} onClick={isLoading ? undefined : onToggleExpand}> + {isLoading && ( +
+ +
+ )} {isFeedback || isConsoleLogs ? (
Date: Fri, 18 Apr 2025 16:03:58 +0700 Subject: [PATCH 2/3] fix(chat): missing loading aria role Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --- webview-ui/src/components/common/CodeAccordian.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webview-ui/src/components/common/CodeAccordian.tsx b/webview-ui/src/components/common/CodeAccordian.tsx index 3673135674..e73d298d18 100644 --- a/webview-ui/src/components/common/CodeAccordian.tsx +++ b/webview-ui/src/components/common/CodeAccordian.tsx @@ -71,7 +71,7 @@ const CodeAccordian = ({ onClick={isLoading ? undefined : onToggleExpand}> {isLoading && (
- +
)} {isFeedback || isConsoleLogs ? ( From c3d9ff0bf3589ba3af8517cb8b1233e68f7dbbdd Mon Sep 17 00:00:00 2001 From: elianiva <51877647+elianiva@users.noreply.github.com> Date: Wed, 23 Apr 2025 22:06:12 +0700 Subject: [PATCH 3/3] refactor(chat): use vscode loading for more consistency --- webview-ui/src/components/common/CodeAccordian.tsx | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/webview-ui/src/components/common/CodeAccordian.tsx b/webview-ui/src/components/common/CodeAccordian.tsx index c4123f31e1..ec39e1704a 100644 --- a/webview-ui/src/components/common/CodeAccordian.tsx +++ b/webview-ui/src/components/common/CodeAccordian.tsx @@ -2,6 +2,7 @@ import { memo, useMemo } from "react" import { getLanguageFromPath } from "@src/utils/getLanguageFromPath" import CodeBlock, { CODE_BLOCK_BG_COLOR } from "./CodeBlock" import { ToolProgressStatus } from "@roo/shared/ExtensionMessage" +import { VSCodeProgressRing } from "@vscode/webview-ui-toolkit/react" interface CodeAccordianProps { code?: string @@ -71,11 +72,7 @@ const CodeAccordian = ({ }} className={`${isLoading ? "animate-pulse" : ""}`} onClick={isLoading ? undefined : onToggleExpand}> - {isLoading && ( -
- -
- )} + {isLoading && } {isFeedback || isConsoleLogs ? (