-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix comment slop. #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comment slop. #3077
Conversation
|
|
The changes in this pull request are focused on removing redundant comments and cleaning up code formatting across multiple files. These changes are consistent and related, as they aim to improve code readability and maintainability by removing unnecessary comments. Therefore, it makes sense to keep them in a single pull request for consistency. |
|
Some of the Regex removables might be usefully explanatory. (it is regex after all) So Is there going to be / should be a prohibition against all the trigger words for comments? Or as a project we agree that "all human written comments" use |
I agree. I did limit character length to 30 chars — anything beyond that stayed — and I did a quick manual pass for anything that looked valuable WITHIN the captured lines. This is, granted, otherwise a blunt measure.
Sooner or later the AI is going to adapt and start feeding triple-slash slop into the codebase, so I don't think that'll work. However, I think this is also going to get fixed in the models within 3-6 months so this is just a temporary sanity measure? |
|
Closing this one. Will re-open after #3235 is merged. |
Quick comment slop fix. Hopefully fewer of these being fed into context means the LLMs (looking at you, Gemini... 👀) are less eager to add even more.
Regex used:
Plain english: "Look for //, followed by [Add(ed), Remove(d), Update(d)...], followed by up to thirty characters and then a newline.
Important
Remove specific types of comments across multiple files to improve code readability and maintainability.
\/\/[^\S\n]+(?:Add|Remove|Update|Import|Restore).{1,30}(\n)across various files.//followed by keywords likeAdd,Remove,Update, etc.gemini.test.ts,mistral.test.ts,deepseek.ts,cache-strategy.test.ts,base-strategy.ts,Cline.ts,Cline.test.ts,ContextProxy.ts,CustomModesManager.ts,insert-groups.ts,multi-search-replace.test.ts,index.ts,system.test.ts.snap,system.test.ts,custom-system-prompt.test.ts,custom-instructions.ts,index.ts,executeCommandTool.test.ts,applyDiffTool.ts,ClineProvider.ts,ClineProvider.test.ts,webviewMessageHandler.ts,DiffViewProvider.ts,processCarriageReturns.benchmark.ts,extract-text.ts,read-lines.ts,ShellIntegrationManager.ts,Terminal.ts,TerminalProcess.ts,TerminalProcess.test.ts,TerminalProcessExec.bash.test.ts,TerminalProcessExec.cmd.test.ts,TerminalProcessExec.pwsh.test.ts,TerminalRegistry.test.ts,bashStream.ts,BrowserSession.ts,browserDiscovery.ts,ShadowCheckpointService.test.ts,McpHub.ts,McpHub.test.ts,file-search.ts,sample-rust.ts,languageParser.test.ts,index.ts,modes.ts,shell.test.ts,CompactTransport.test.ts,BrowserSessionRow.tsx,ChatView.tsx,ChatTextArea.test.tsx,TaskHeader.test.tsx,CodeBlock.tsx,MermaidBlock.tsx,SettingsView.test.tsx,TemperatureControl.test.tsx,select-dropdown.tsx,RooTips.test.tsx,ExtensionStateContext.tsx,command-validation.ts,context-mentions.ts,highlight.ts.This description was created by
for 9ce967b. You can customize this summary. It will automatically update as commits are pushed.