-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: move play audio to webview to ensure cross-platform #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
48dc6cb to
e443218
Compare
|
@cte what do you think if we migrate to Vitest? |
cdfd3d3 to
6201c98
Compare
|
sound from this PR works for me on my Linux system (Oracle Linux 9, a RHEL 9 clone) |
60ec784 to
63c8062
Compare
* downloadMcp protobus migration * added setIsDownloading(false) to error handling
replace sound-play with use-sound for audio handling and add new sound files
63c8062 to
1fc13a9
Compare
|
sr for force push, can you test again @SmartManoj @KJ7LNW ? |
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested but the code seems reasonable to me. Have you confirmed that it works both in debug as well as in a built vsix?
@mrubens i remember @SmartManoj has test and build to vsix to test, i have commit from him |
|
audio still works for me as of the current PR state |
|
I think this PR introduced the following error: index.html?id=26a653…se=webviewView:1060 The source list for the Content Security Policy directive 'connect-src' contains an invalid source: 'https://file+.vscode-resource.vscode-cdn.net'. It will be ignored. here: |
here is one that you can use: |
|
Can you use newest version?
…On Fri, 16 May 2025 at 04:29 KJ7LNW ***@***.***> wrote:
*KJ7LNW* left a comment (RooCodeInc/Roo-Code#3487)
<#3487 (comment)>
...test and build to vsix to test
here is one that you can use:
https://www.linuxglobal.com/out/roo/roo-cline-3.17.0-feat-move-audio-to-webview.vsix
—
Reply to this email directly, view it on GitHub
<#3487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7VCZVRYW7BEEEDKVJZ5YL26UBJZAVCNFSM6AAAAAB444F4VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBVGA4TIOBQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I tested as a one hour ago and it worked, I do not see any new commit messages. Is there something else for me to test? ]$ gh pr checkout 3487 --repo RooVetGit/Roo-Code
From https://github.com/RooVetGit/Roo-Code
* branch refs/pull/3487/head -> FETCH_HEAD
Already up to date. |
that's weird, don't know why it still have error |
|
@samhvw8, Would you please remove the mention in the commit message? Side effects |
Why did CI not captured that? |
yeah that's strange |
|
@SmartManoj thanks for extend my work, close because we have this pr #3659 |
|
1fc13a9 It's not Windows related, but it addresses the following: "The extension worked in dev mode but not in build mode." |
replace sound-play with use-sound for audio handling and add new sound files
Related GitHub Issue
Closes: #2187
Description
Move backend (node) play audio to webview play audio
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Important
Replaces
sound-playwithuse-soundfor webview audio handling, moving playback from backend to frontend.sound-playwithuse-soundfor audio handling inChatView.tsx.playSoundhandler fromwebviewMessageHandler.ts.sound-playfrompackage.json.use-soundtowebview-ui/package.json.sound.tswhich contained sound utility functions.ClineProvider.test.tsandChatView.test.tsxto mockuse-soundand verify sound behavior.vite.config.tsto include.wavfiles inassetsInclude.This description was created by
for 48dc6cb7e2470cdf0f6664c59ecfe139b3120df0. You can customize this summary. It will automatically update as commits are pushed.