-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Improve file read truncation UX with tooltips and consistent line range notifications #3633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0cccb22
enhance readFileTool with auto-truncate handling
cannuri f36e516
hide maxReadFileLine truncation message for explicit line range reads
cannuri 71cfa74
fix: Always display line range notification in readFileTool regardles…
cannuri 83e4e7e
Add localization support for readFile tool across multiple languages
cannuri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (línies {{start}}-{{end}})", | ||
| "linesFromToEnd": " (línies {{start}}-final)", | ||
| "linesFromStartTo": " (línies 1-{{end}})", | ||
| "definitionsOnly": " (només definicions)", | ||
| "maxLines": " (màxim {{max}} línies)", | ||
| "autoTruncateTooltip": "Per ajustar aquest límit, feu clic a la icona '{{settings}}' (⚙️) al panell de Roo-Code, després feu clic a '{{context}}' i trobeu l'opció '{{threshold}}'." | ||
| }, | ||
| "toolRepetitionLimitReached": "Sembla que Roo està atrapat en un bucle, intentant la mateixa acció ({{toolName}}) repetidament. Això podria indicar un problema amb la seva estratègia actual. Considereu reformular la tasca, proporcionar instruccions més específiques o guiar-lo cap a un enfocament diferent." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (Zeilen {{start}}-{{end}})", | ||
| "linesFromToEnd": " (Zeilen {{start}}-Ende)", | ||
| "linesFromStartTo": " (Zeilen 1-{{end}})", | ||
| "definitionsOnly": " (nur Definitionen)", | ||
| "maxLines": " (maximal {{max}} Zeilen)", | ||
| "autoTruncateTooltip": "Um dieses Limit anzupassen, klicke auf das '{{settings}}'-Symbol (⚙️) im Roo-Code-Panel, dann auf '{{context}}' und finde die Option '{{threshold}}'." | ||
| }, | ||
| "toolRepetitionLimitReached": "Roo scheint in einer Schleife festzustecken und versucht wiederholt dieselbe Aktion ({{toolName}}). Dies könnte auf ein Problem mit der aktuellen Strategie hindeuten. Überlege dir, die Aufgabe umzuformulieren, genauere Anweisungen zu geben oder Roo zu einem anderen Ansatz zu führen." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (lines {{start}}-{{end}})", | ||
| "linesFromToEnd": " (lines {{start}}-end)", | ||
| "linesFromStartTo": " (lines 1-{{end}})", | ||
| "definitionsOnly": " (definitions only)", | ||
| "maxLines": " (max {{max}} lines)", | ||
| "autoTruncateTooltip": "To adjust this limit, click the '{{settings}}' icon (⚙️) in the Roo-Code panel, then click on '{{context}}' and find the '{{threshold}}' option." | ||
| }, | ||
| "toolRepetitionLimitReached": "Roo appears to be stuck in a loop, attempting the same action ({{toolName}}) repeatedly. This might indicate a problem with its current strategy. Consider rephrasing the task, providing more specific instructions, or guiding it towards a different approach." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (líneas {{start}}-{{end}})", | ||
| "linesFromToEnd": " (líneas {{start}}-final)", | ||
| "linesFromStartTo": " (líneas 1-{{end}})", | ||
| "definitionsOnly": " (solo definiciones)", | ||
| "maxLines": " (máximo {{max}} líneas)", | ||
| "autoTruncateTooltip": "Para ajustar este límite, haz clic en el icono '{{settings}}' (⚙️) en el panel de Roo-Code, luego en '{{context}}' y busca la opción '{{threshold}}'." | ||
| }, | ||
| "toolRepetitionLimitReached": "Roo parece estar atrapado en un bucle, intentando la misma acción ({{toolName}}) repetidamente. Esto podría indicar un problema con su estrategia actual. Considera reformular la tarea, proporcionar instrucciones más específicas o guiarlo hacia un enfoque diferente." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (lignes {{start}}-{{end}})", | ||
| "linesFromToEnd": " (lignes {{start}}-fin)", | ||
| "linesFromStartTo": " (lignes 1-{{end}})", | ||
| "definitionsOnly": " (définitions uniquement)", | ||
| "maxLines": " (max {{max}} lignes)", | ||
| "autoTruncateTooltip": "Pour ajuster cette limite, clique sur l'icône '{{settings}}' (⚙️) dans le panneau Roo-Code, puis sur '{{context}}' et trouve l'option '{{threshold}}'." | ||
| }, | ||
| "toolRepetitionLimitReached": "Roo semble être bloqué dans une boucle, tentant la même action ({{toolName}}) de façon répétée. Cela pourrait indiquer un problème avec sa stratégie actuelle. Envisage de reformuler la tâche, de fournir des instructions plus spécifiques ou de le guider vers une approche différente." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "readFile": { | ||
| "linesRange": " (लाइन {{start}}-{{end}})", | ||
| "linesFromToEnd": " (लाइन {{start}}-अंत)", | ||
| "linesFromStartTo": " (लाइन 1-{{end}})", | ||
| "definitionsOnly": " (केवल परिभाषाएँ)", | ||
| "maxLines": " (अधिकतम {{max}} लाइनें)", | ||
| "autoTruncateTooltip": "इस सीमा को समायोजित करने के लिए, Roo-Code पैनल में '{{settings}}' आइकन (⚙️) पर क्लिक करें, फिर '{{context}}' पर क्लिक करें और '{{threshold}}' विकल्प खोजें।" | ||
| }, | ||
| "toolRepetitionLimitReached": "ऐसा लगता है कि Roo एक लूप में फंस गया है, बार-बार एक ही क्रिया ({{toolName}}) का प्रयास कर रहा है। यह उसकी वर्तमान रणनीति में किसी समस्या का संकेत हो सकता है। कार्य को पुनः प्रस्तुत करने, अधिक विशिष्ट निर्देश देने, या इसे एक अलग दृष्टिकोण की ओर निर्देशित करने पर विचार करें।" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I understand that the translation
autoTruncateTooltipis now necessary on the webview, it seems like it's the only translation currently used from this file, we might want to clean this up and only leave the used translation.If leaving a locale file with a single translation key is undesirable then it might be a good idea to move it to
chat.json.