-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: Add vertical resize to VSCodeTextArea internal part #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
thank you FOR ADDING THIS BACK! |
|
Do you know how this used to work? I’m still confused about exactly what changed. I don’t think we needed this css before though? |
this used to work by passing a prop to the VSCodeTextArea, i forgot to add it back when we reverted from regular textarea (sorry!) for some reason the css that i used for text area you need to pass |
I think the “some reasons” you said here are due to CSS specificity issues. When working on this PR, both Roo and my multiple rounds of debugging pointed to the same conclusion. |
|
Sorry, I’m not 100% following. Can we try to get this back to the way it used to work where you only needed to add the resize=vertical for the resizing UI to show up? |
|
Does #3739 look right? |
|
I merged #3739, thank you for the help tracking down the issue all! |
* adding docs links to rules modal * changeset --------- Co-authored-by: Cline Evaluation <[email protected]>
Related GitHub Issue
Closes: #3691
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
2025-05-17.221830.mp4