Skip to content

Conversation

@monkeyDluffy6017
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 commented May 19, 2025

Related GitHub Issue

No issue

Description

The icon in select model for interaction is not displaying correctly

Test Procedure

I have shown in the picture

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

before:
image

after:
image

Documentation Updates

Additional Notes


Important

Fixes incorrect icon display for debug and orchestrator modes in modes.ts.

  • Bug Fix:
    • Corrects icon display for debug mode from 🪲 to 🐞 in modes.ts.
    • Corrects icon display for orchestrator mode from 🪃 to 🧩 in modes.ts.

This description was created by Ellipsis for 50fbdb8. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: a5e4d0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels May 19, 2025
@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: agent icon error fix: icon in select model May 19, 2025
@elianiva
Copy link
Contributor

hmm this could be a temporary solution, but we had a discussion a while back to just bundle an emoji font instead so people have the same consistet experience no matter what OS or fonts they're using (windows, macos, linux, all have different emoji)

what do you think?

@monkeyDluffy6017
Copy link
Contributor Author

Do you have any recommended emoji fonts? @elianiva

@elianiva
Copy link
Contributor

Do you have any recommended emoji fonts? @elianiva

we came to a conclusion on using noto emoji since it supports a wide range of emoji that people can use

if you can implement that instead that would be mega, haven't got the time to do that myself

should be easy enough to do, you can check how we bundle stuff for the vsix build by looking at how we did it for material icons

@monkeyDluffy6017
Copy link
Contributor Author

Do you have any recommended emoji fonts? @elianiva

we came to a conclusion on using noto emoji since it supports a wide range of emoji that people can use

if you can implement that instead that would be mega, haven't got the time to do that myself

should be easy enough to do, you can check how we bundle stuff for the vsix build by looking at how we did it for material icons

let me have a try

@hannesrudolph
Copy link
Collaborator

@monkeyDluffy6017 why change the boomerang to a puzzle piece?

@hannesrudolph
Copy link
Collaborator

Also can you please follow the issues first approach in the contributing doc.

@monkeyDluffy6017
Copy link
Contributor Author

@monkeyDluffy6017 why change the boomerang to a puzzle piece?

I can't see the boomerang in my system, so i guess it's a bug

@monkeyDluffy6017
Copy link
Contributor Author

Also can you please follow the issues first approach in the contributing doc.

For complex features or bugs, I would always start by opening an issue for discussion(#3484), but since this was a clear-cut and straightforward bug, I directly submitted a pull request with the fix.

@hannesrudolph
Copy link
Collaborator

Do you have any recommended emoji fonts? @elianiva

we came to a conclusion on using noto emoji since it supports a wide range of emoji that people can use
if you can implement that instead that would be mega, haven't got the time to do that myself
should be easy enough to do, you can check how we bundle stuff for the vsix build by looking at how we did it for material icons

let me have a try

Can we close this one then?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph
Copy link
Collaborator

Replacing the boomerang is not the answer.

@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants