-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: icon in select model
#3728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icon in select model
#3728
Conversation
|
|
hmm this could be a temporary solution, but we had a discussion a while back to just bundle an emoji font instead so people have the same consistet experience no matter what OS or fonts they're using (windows, macos, linux, all have different emoji) what do you think? |
|
Do you have any recommended emoji fonts? @elianiva |
we came to a conclusion on using noto emoji since it supports a wide range of emoji that people can use if you can implement that instead that would be mega, haven't got the time to do that myself should be easy enough to do, you can check how we bundle stuff for the vsix build by looking at how we did it for material icons |
let me have a try |
|
@monkeyDluffy6017 why change the boomerang to a puzzle piece? |
|
Also can you please follow the issues first approach in the contributing doc. |
I can't see the boomerang in my system, so i guess it's a bug |
For complex features or bugs, I would always start by opening an issue for discussion(#3484), but since this was a clear-cut and straightforward bug, I directly submitted a pull request with the fix. |
Can we close this one then? |
|
Replacing the boomerang is not the answer. |
Related GitHub Issue
No issue
Description
The icon in
select model for interactionis not displaying correctlyTest Procedure
I have shown in the picture
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
before:

after:

Documentation Updates
Additional Notes
Important
Fixes incorrect icon display for
debugandorchestratormodes inmodes.ts.debugmode from🪲to🐞inmodes.ts.orchestratormode from🪃to🧩inmodes.ts.This description was created by
for 50fbdb8. You can customize this summary. It will automatically update as commits are pushed.