Skip to content

Ability to refresh LiteLLM models list (take 2) #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 23, 2025
Merged

Ability to refresh LiteLLM models list (take 2) #3852

merged 10 commits into from
May 23, 2025

Conversation

@slytechnical
Copy link
Contributor

@slytechnical slytechnical commented May 22, 2025 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #3613

Description

  • adds comprehensive test coverage for requestRouterModels message handling in webview
  • adds proper error handling for individual provider failures using Promise.allSettled
  • adds support for LiteLLM configuration values from message when config is missing
  • adds UI improvements to LiteLLM provider with refresh models button and status feedback
  • adds GetModelsOptions type for better type safety in model fetching
  • refactors model fetching to handle provider-specific failures gracefully

Test Procedure

  1. Unit Tests: Run npm test to verify all new test cases pass
  2. Manual Testing:
    • Open Roo Code settings and select LiteLLM provider
    • Enter API key and base URL, click "Refresh Models" button
    • Verify loading states and error handling work correctly
    • Test with invalid credentials to verify error messages display
    • Test other router model providers to ensure no regression

Type of Change

  • ✨ New Feature: Non-breaking change that adds functionality.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 🧪 Testing: Adds comprehensive test coverage for existing functionality.

Screenshots / Videos

Screen.Recording.2025-05-22.at.1.40.08.PM.mov

Documentation Updates

  • No documentation updates are required.

Important

Adds functionality to refresh LiteLLM models with improved error handling, UI enhancements, and comprehensive test coverage.

  • Behavior:
    • Adds a refresh button for LiteLLM models in the UI with status feedback.
    • Implements Promise.allSettled for error handling of provider failures in webviewMessageHandler.ts.
    • Supports LiteLLM configuration from messages if config is missing.
  • Types and Refactoring:
    • Introduces GetModelsOptions type for fetching models with type safety.
    • Refactors model fetching to handle provider-specific failures gracefully in modelCache.ts.
  • Testing:
    • Adds comprehensive tests for getLiteLLMModels in litellm.test.ts.
    • Tests getModels function in modelCache.test.ts for various providers.
    • Tests requestRouterModels message handling in ClineProvider.test.ts and webviewMessageHandler.test.ts.

This description was created by Ellipsis for aa061bd. You can customize this summary. It will automatically update as commits are pushed.

@slytechnical slytechnical requested review from cte and mrubens as code owners May 22, 2025 18:42
@slytechnical slytechnical mentioned this pull request May 22, 2025
Closed
23 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems May 22, 2025
View reviewed changes
@wickhu
Copy link

wickhu commented May 23, 2025

Good Job

cte
cte approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@cte cte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slytechnical slytechnical merged commit 1791bb9 into main May 23, 2025
12 checks passed
@slytechnical slytechnical deleted the litellm-model-refresh-simple branch May 23, 2025 21:19
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cte cte cte approved these changes

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LiteLLM model list not updating

4 participants

@slytechnical @wickhu @cte