Fix changelog generation #3856
Merged
Fix changelog generation #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| print(f"latest version: {VERSION}") | ||
| print(f"prev_version: {PREV_VERSION}") | ||
|
|
||
| notes_start_index = changelog_text.find(version_pattern) + len(version_pattern) |
Contributor
There was a problem hiding this comment.
No check if '## {VERSION}\n' exists. If not found, find() returns -1, causing an incorrect slice. Add validation.
| + parsed_lines | ||
| + changelog_text[notes_end_index:] | ||
| ) | ||
| updated_changelog = updated_changelog.replace( |
Contributor
There was a problem hiding this comment.
Global replacement of ## {VERSION} with ## [{VERSION}] can inadvertently alter other parts of the file. Limit the replacement to the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accidentally deleted this script.
Important
Restores script to update or reformat changelog sections for specific versions using environment variables.
overwrite_changeset_changelog.pyto update or reformatCHANGELOG.md.CHANGELOG_PATH,VERSION,PREV_VERSION, andNEW_CONTENT..changeset/cold-donuts-clean.mdfor changelog entry.This description was created by
for 32e0c72. You can customize this summary. It will automatically update as commits are pushed.