Fix global settings export #3890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
maxAllowedRequestsvalue seems to benullin some cases. I'm not sure why; I wonder if it has to do with zod andInfinity. This ends up removing global settings from exports due to the schema parse error. I've allowed null values for now.Important
Fix export issue by allowing
allowedMaxRequeststo benullin global settings.allowedMaxRequeststo benullinglobalSettingsSchemainschemas/index.ts.ClineProviderinClineProvider.tsto handleallowedMaxRequestswithout defaulting toInfinity.allowedMaxRequestsis correctly handled inSettingsView.tsx.importExport.test.tsto verify global settings export whenallowedMaxRequestsisnull.GlobalSettingstype inroo-code.d.tsandtypes.tsto allowallowedMaxRequeststo benull.young-buckets-fold.mdto document the patch.This description was created by
for 416a595. You can customize this summary. It will automatically update as commits are pushed.