Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 23, 2025

Description

The maxAllowedRequests value seems to be null in some cases. I'm not sure why; I wonder if it has to do with zod and Infinity. This ends up removing global settings from exports due to the schema parse error. I've allowed null values for now.


Important

Fix export issue by allowing allowedMaxRequests to be null in global settings.

  • Behavior:
    • Allow allowedMaxRequests to be null in globalSettingsSchema in schemas/index.ts.
    • Update ClineProvider in ClineProvider.ts to handle allowedMaxRequests without defaulting to Infinity.
    • Ensure allowedMaxRequests is correctly handled in SettingsView.tsx.
  • Tests:
    • Add test in importExport.test.ts to verify global settings export when allowedMaxRequests is null.
  • Types:
    • Update GlobalSettings type in roo-code.d.ts and types.ts to allow allowedMaxRequests to be null.
  • Misc:
    • Add changeset young-buckets-fold.md to document the patch.

This description was created by Ellipsis for 416a595. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner May 23, 2025 08:29
@cte cte merged commit 6931cc9 into main May 23, 2025
15 checks passed
@cte cte deleted the cte/fix-export branch May 23, 2025 08:33
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
* Scroll to message onclick from task timeline

* version

* fixing ellipsis-dev's suggestion on potential infinite loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants