refactor: simplify object assignment & use startsWith

[noritaka1166]

Related GitHub Issue

No issue

Description

• Use an object spread instead of Object.assign eg: { ...foo }.
  • https://next.sonarqube.com/sonarqube/coding_rules?open=typescript%3AS6661&rule_key=typescript%3AS6661
• Use 'String#startsWith' method instead.
  • https://cloud-ci.sgs.com/sonar/coding_rules?open=typescript%3AS6557&rule_key=typescript%3AS6557

Test Procedure

no

Type of Change

• 🐛 Bug Fix: Non-breaking change that fixes an issue.
• ✨ New Feature: Non-breaking change that adds functionality.
• 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
• ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
• 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
• 📚 Documentation: Updates to documentation files.
• ⚙️ Build/CI: Changes to the build process or CI configuration.
• 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Code Quality:
  • My code adheres to the project's style guidelines.
  • There are no new linting errors or warnings (npm run lint).
  • All debug code (e.g., console.log) has been removed.
• Testing:
  • New and/or updated tests have been added to cover my changes.
  • All tests pass locally (npm test).
  • The application builds successfully with my changes.
• Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

no

Documentation Updates

no

Additional Notes

no

Get in Touch

noritaka1166

---

Important

Refactor to simplify object assignment in vscode-lm-format.ts and use startsWith() for platform check in index.ts.

• Refactor:
  • Simplify object assignment in asObjectSafe() in vscode-lm-format.ts by using spread operator instead of Object.assign().
  • Use startsWith() instead of regex in index.ts to check if the platform is Windows.

^{This description was created by for ef0c056. You can customize this summary. It will automatically update as commits are pushed.}

[hannesrudolph]

This PR is labeled as a refactor but doesn’t describe the motivation behind the changes. Could you briefly explain why these changes are beneficial or necessary? Without additional context, it’s difficult to effectively review.

In the future, please create an issue first and link it to your PR for better clarity and context.

[noritaka1166]

This PR is labeled as a refactor but doesn’t describe the motivation behind the changes. Could you briefly explain why these changes are beneficial or necessary? Without additional context, it’s difficult to effectively review.

In the future, please create an issue first and link it to your PR for better clarity and context.

@hannesrudolph
I'm sorry I didn't explain it enough.
I added some information.