Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #3725
Description
OpenRouter's
supported_parametersindicates thattemperatureis allowed but it is not. We're manually stripping it for now, but longer term we should add this toModelInfo.I also switched some test from jest to vitest to see how smoothly that can go (it's not bad).
Important
Fixes
temperatureparameter handling for specific models in OpenRouter and switches tests from Jest to Vitest.temperatureparameter foro1,o1-preview,o1-mini,o3-mini, ando1-promodels ingetModelParams()inmodel-params.ts.openai-native.spec.tsto verifytemperaturehandling for these models.ollama.spec.ts,openai-native.spec.ts,openai-usage-tracking.spec.ts, andopenai.spec.ts.vitest.fn()andvitest.mock().vitest.config.tsto include global test settings.This description was created by
for efa6a56. You can customize this summary. It will automatically update as commits are pushed.