Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 24, 2025

Related GitHub Issue

Closes: #3725

Description

OpenRouter's supported_parameters indicates that temperature is allowed but it is not. We're manually stripping it for now, but longer term we should add this to ModelInfo.

I also switched some test from jest to vitest to see how smoothly that can go (it's not bad).


Important

Fixes temperature parameter handling for specific models in OpenRouter and switches tests from Jest to Vitest.

  • Behavior:
    • Strips temperature parameter for o1, o1-preview, o1-mini, o3-mini, and o1-pro models in getModelParams() in model-params.ts.
    • Adds tests in openai-native.spec.ts to verify temperature handling for these models.
  • Testing:
    • Switches from Jest to Vitest in ollama.spec.ts, openai-native.spec.ts, openai-usage-tracking.spec.ts, and openai.spec.ts.
    • Updates mock implementations to use vitest.fn() and vitest.mock().
  • Misc:
    • Updates vitest.config.ts to include global test settings.

This description was created by Ellipsis for efa6a56. You can customize this summary. It will automatically update as commits are pushed.

@cte cte merged commit 2cfb966 into main May 24, 2025
12 checks passed
@cte cte deleted the cte/fix-o1-pro branch May 24, 2025 06:11
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 24, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

01 pro not working

2 participants