Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented May 25, 2025

Closes: #3964

Important

Fixes settings saving logic in CodeIndexManager to ensure saved settings are applied and used, with added tests for configuration change handling.

  • Behavior:
    • Updates webviewMessageHandler to ensure CodeIndexManager uses saved settings and starts indexing if configured and enabled.
    • Adds logic to CodeIndexConfigManager to detect configuration changes that require a restart, including provider and model changes.
    • Ensures CodeIndexManager restarts services if configuration changes require it.
  • Tests:
    • Adds tests in config-manager.test.ts to verify restart detection logic for various configuration changes.
    • Adds tests in manager.test.ts to ensure handleExternalSettingsChange works correctly when manager is uninitialized or initialized.
    • Adds tests in service-factory.test.ts to verify embedder and vector store creation logic.
  • UI:
    • Updates CodeIndexSettings.tsx to handle provider and model selection changes, ensuring correct model ID is used for the selected provider.

This description was created by Ellipsis for 487e74b. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens merged commit 6a8fb59 into RooCodeInc:main May 25, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 25, 2025
@daniel-lxs daniel-lxs deleted the fix-saving-model-selection branch May 26, 2025 11:12
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
* migrate settingsButtonClicked

* changeset

* add provider type filtering

---------

Co-authored-by: Elephant Lumps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Codebase Indexing: Wrong OpenAI model is being used -small instead of -large when large is selected

2 participants