Better handling of cloud login/out with multiple workspaces #4196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| this.fetchUserInfo() | ||
| await this.storeCredentials(credentials) | ||
|
|
Contributor
There was a problem hiding this comment.
After storing credentials in handleCallback, consider invoking handleCredentialsChange() directly to immediately update the in-memory state rather than solely relying on onDidChange events.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
mrubens
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the persistent auth data into a single secret and listen for updates to it. Some rearranging of AuthService logic to reduce duplication.
Important
Improves
AuthServiceby consolidating auth credentials into a single secret, enhancing state management, and addingzodfor validation.clientTokenandsessionIdintocredentialsobject inAuthService.ts.authCredentialsSchemausingzodfor validation.handleCredentialsChange(),transitionToLoggedOut(), andtransitionToInactiveSession()for state management.AUTH_CREDENTIALS_KEY.clerkSignIn()to returncredentialsobject.onDidChangeevent to handle credential updates.zodtodependenciesinpackage.json.This description was created by
for 9a30535. You can customize this summary. It will automatically update as commits are pushed.