Revert "Revert "fix: prevent dump of an entire file into the context on user edit "" #4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on user …" This reverts commit 98f5542.
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| await task.say("user_feedback_diff", JSON.stringify(say)) | ||
| } | ||
|
|
||
| // Build XML response |
Contributor
There was a problem hiding this comment.
The new pushToolWriteResult method standardizes XML response generation for file write operations. Consider wrapping the XML builder call in a try/catch block so that any unexpected formatting errors can be caught and logged without crashing the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4211
Should be able to bring this back now with the test fix included in #4210 (thanks @taylorwilsdon!)
Important
Reintroduces changes to handle user edits and file operations more effectively by updating
DiffViewProviderand related tools.applyDiffTool,insertContentTool,searchAndReplaceTool, andwriteToFileToolto useDiffViewProvider.pushToolWriteResult()for handling user edits and generating XML responses.pushToolWriteResult()to format XML responses for file operations.newProblemsMessageanduserEditsfor use in response formatting.saveChanges()to track user edits and new problems.addLineNumbersimport fromapplyDiffTool.tsandwriteToFileTool.ts.This description was created by
for ba43828. You can customize this summary. It will automatically update as commits are pushed.