Skip to content

Add proper error handling for API conversation history issues #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Add proper error handling for API conversation history issues #4312

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a68c1
fix: add debug logging for API conversation history issues
Jun 4, 2025
9d19c68
fix: wrap JSON.parse calls in try/catch blocks
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/core/task-persistence/apiMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,34 @@ export async function readApiMessages({
const filePath = path.join(taskDir, GlobalFileNames.apiConversationHistory)

if (await fileExistsAtPath(filePath)) {
return JSON.parse(await fs.readFile(filePath, "utf8"))
const fileContent = await fs.readFile(filePath, "utf8")
const parsedData = JSON.parse(fileContent)
if (Array.isArray(parsedData) && parsedData.length === 0) {
console.error(
`[Roo-Debug] readApiMessages: Found API conversation history file, but it's empty. TaskId: ${taskId}, Path: ${filePath}`,
)
}
return parsedData
} else {
const oldPath = path.join(taskDir, "claude_messages.json")

if (await fileExistsAtPath(oldPath)) {
const data = JSON.parse(await fs.readFile(oldPath, "utf8"))
const fileContent = await fs.readFile(oldPath, "utf8")
const parsedData = JSON.parse(fileContent)
if (Array.isArray(parsedData) && parsedData.length === 0) {
console.error(
`[Roo-Debug] readApiMessages: Found OLD API conversation history file (claude_messages.json), but it's empty. TaskId: ${taskId}, Path: ${oldPath}`,
)
}
await fs.unlink(oldPath)
return data
return parsedData
}
}

// If we reach here, neither the new nor the old history file was found.
console.error(
`[Roo-Debug] readApiMessages: API conversation history file not found for taskId: ${taskId}. Expected at: ${filePath}`,
)
return []
}

Expand Down