Skip to content

Conversation

@olweraltuve
Copy link
Contributor

@olweraltuve olweraltuve commented Jun 4, 2025

Related GitHub Issue

Closes: #3008

Description

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Enhances Gemini 2.5 flash model's reasoning capabilities, updates build and linting scripts, and adds UI support for manual thinking budget.

  • Behavior:
    • requiredReasoningBudget set to false for gemini-2.5-flash-preview-04-17 and gemini-2.5-flash-preview-05-20 in gemini.ts and vertex.ts.
    • GeminiHandler and VertexHandler updated to include includeThoughts in thinkingConfig.
    • ThinkingBudget.tsx defaults to enabling reasoning for Gemini Flash models if not set.
  • Build and Linting:
    • Removed --ext=ts from lint scripts in package.json files across multiple packages.
    • Updated .husky/pre-push to handle pnpm command detection on Windows.
  • UI and Localization:
    • Added manual thinking budget option in ThinkingBudget.tsx.
    • Updated translations in multiple settings.json files for new thinking budget feature.

This description was created by Ellipsis for 0e223f4. You can customize this summary. It will automatically update as commits are pushed.

@olweraltuve olweraltuve requested review from cte and mrubens as code owners June 4, 2025 07:10
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 4, 2025
@olweraltuve olweraltuve marked this pull request as draft June 4, 2025 07:11
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 4, 2025
…ini-2.5-flash-determining-its-own-thinking
…dels

- Changed requiredReasoningBudget to false for Gemini Flash models in the model definitions.
- Updated Gemini and Vertex handlers to set thinkingConfig appropriately.
- Added UI in ThinkingBudget component for Gemini Flash models: a checkbox to enable manual thinking budget and conditionally show the slider.
- Added new i18n key 'manualThinkingBudget' for the checkbox label.
…uages

- Added translations for the new 'manualThinkingBudget' key in the settings.json files for the following languages: Catalan, Hindi, Korean, Dutch, Polish, Turkish, Vietnamese, and Traditional Chinese.
@olweraltuve olweraltuve marked this pull request as ready for review June 5, 2025 17:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working enhancement New feature or request and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 5, 2025
@hannesrudolph
Copy link
Collaborator

The approved issue does not contain anything about a new feature.

@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jun 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 5, 2025
@hannesrudolph hannesrudolph reopened this Jun 5, 2025
@github-project-automation github-project-automation bot moved this from Done to New in Roo Code Roadmap Jun 5, 2025
@github-project-automation github-project-automation bot moved this from Done to Triage in Roo Code Roadmap Jun 5, 2025
@hannesrudolph
Copy link
Collaborator

Closed in favour of #4386

@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request PR - Draft / In Progress size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Support gemini-2.5-flash determining its own thinking budget

3 participants