Get rid of "partial" component in names referencing not necessarily partial messages #4332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4087
Description
Renames:
partialMessageparameter ofTask.updateClineMessagetomessagepartialMessagevariant ofExtensionMessagetoupdateMessageandExtensionMessage.partialMessagefield toclineMessageWhy: such renames makes code more readable and decrease developer confusion when final/complete message is passed.
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).¹console.log) has been removed.npm test).²mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.¹
npm run lintfails with message:Invalid option '--ext' - perhaps you meant '-c'?²
npm testshows pin-entry to use my private GPG keys without any explanation why it wants the keys — therefore I couldn't run testsScreenshots / Videos
Documentation Updates
No documentation updates are required.
Additional Notes
Get in Touch
Discord handle: wkordalski
Important
Renames
partialMessagereferences to improve clarity inTask.ts,ExtensionMessage.ts, andExtensionStateContext.tsx.partialMessageparameter inTask.updateClineMessagetomessageinTask.ts.partialMessagevariant ofExtensionMessagetomessageUpdatedandExtensionMessage.partialMessagefield toclineMessageinExtensionMessage.ts.ExtensionStateContext.tsxto usemessageUpdatedandclineMessagefor state updates.This description was created by
for 3d1ebc3. You can customize this summary. It will automatically update as commits are pushed.