Skip to content

Conversation

@wkordalski
Copy link
Contributor

@wkordalski wkordalski commented Jun 4, 2025

Related GitHub Issue

Closes: #4087

Description

Renames:

  • partialMessage parameter of Task.updateClineMessage to message
  • partialMessage variant of ExtensionMessage to updateMessage and ExtensionMessage.partialMessage field to clineMessage

Why: such renames makes code more readable and decrease developer confusion when final/complete message is passed.

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).¹
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).²
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

¹ npm run lint fails with message: Invalid option '--ext' - perhaps you meant '-c'?
² npm test shows pin-entry to use my private GPG keys without any explanation why it wants the keys — therefore I couldn't run tests

Screenshots / Videos

Documentation Updates

No documentation updates are required.

Additional Notes

Get in Touch

Discord handle: wkordalski


Important

Renames partialMessage references to improve clarity in Task.ts, ExtensionMessage.ts, and ExtensionStateContext.tsx.

  • Renames:
    • partialMessage parameter in Task.updateClineMessage to message in Task.ts.
    • partialMessage variant of ExtensionMessage to messageUpdated and ExtensionMessage.partialMessage field to clineMessage in ExtensionMessage.ts.
  • Behavior:
    • Updates message handling in ExtensionStateContext.tsx to use messageUpdated and clineMessage for state updates.

This description was created by Ellipsis for 3d1ebc3. You can customize this summary. It will automatically update as commits are pushed.

@wkordalski wkordalski requested review from cte and mrubens as code owners June 4, 2025 15:36
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 4, 2025
@daniel-lxs daniel-lxs added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 4, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 4, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 4, 2025
@mrubens mrubens merged commit d1876d6 into RooCodeInc:main Jun 4, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 4, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Rename variables that suggest that message is partial when it is not necessary

4 participants