Skip to content

Conversation

@elianiva
Copy link
Contributor

@elianiva elianiva commented Jun 4, 2025

Related GitHub Issue

I have been given the grace by Hannes to bypass this and make a direct PR

Description

i tried improving the feature request template to make it easier for people to fill out, there seems to be some misunderstanding in the past, this PR hopefully sort those out

here's what i did:

  • updated it to be more question-answer style to make it easier to fill out / less figuring out what should be added to make the feature proposal clear and actionable
  • added some good examples and poor examples
  • linked references to existing issues if people get confused what 'good' proposal should look like
    feedbacks are much appreciated!

Test Procedure

none, it's an issue template

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

@elianiva


Important

Improves feature request template with a question-answer style, examples, and sections for acceptance criteria and estimated effort.

  • Template Improvements:
    • Updated feature request template to a question-answer style for clarity.
    • Added examples of good and poor proposals to guide users.
    • Included sections for acceptance criteria and estimated effort.
  • Guidance and Process:
    • Emphasized the importance of detailed proposals and the review process.
    • Provided links to resources like the roadmap and Discord for further guidance.
  • Checklist and Optional Sections:
    • Updated checklist to ensure proposals are specific and actionable.
    • Added optional sections for technical considerations and trade-offs.

This description was created by Ellipsis for 8bec555. You can customize this summary. It will automatically update as commits are pushed.

@elianiva elianiva requested review from cte and mrubens as code owners June 4, 2025 17:04
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jun 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 4, 2025
@mrubens mrubens merged commit 72493ad into RooCodeInc:main Jun 4, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 4, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 4, 2025
@elianiva elianiva deleted the chore/improve-feature-request-template branch June 4, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants