#2579 UI fixes for Auto Approve #4371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2579 UI fixes for Auto Approve
Context
This PR introduces a new setting for auto-approving API request limits and refines the visual behavior of auto-approve toggles based on the overall auto-approval state.
Scope
webview-ui/src/components/settings/AutoApproveToggle.tsxto visually indicate when individual auto-approve actions are disabled due to the overall auto-approval being turned off.Expected Output
true.Related GitHub Issue
Closes: #
Description
AutoApproveToggle.tsxcomponent has been updated to provide clearer visual feedback. When the main "Auto-Approve" checkbox is unchecked, individual auto-approve action toggles will now appear with reduced opacity, indicating that they are effectively disabled, regardless of their individualtrueorfalsestate. This improves the user experience by making the overall auto-approval state more intuitive.Test Procedure
Test Auto-Approve Toggle Visuals:
* Open the Auto-Approve menu.
* Ensure some individual auto-approve actions (e.g., "Read-Only", "Write") are enabled (their buttons are in the "default" variant).
* Uncheck the main "Auto-Approve" checkbox at the top of the menu.
* Observe that all individual auto-approve action buttons (e.g., "Read-Only", "Write", "Execute") now appear with reduced opacity, even if their individual settings are still
true.* Check the main "Auto-Approve" checkbox again.
* Verify that the individual auto-approve action buttons return to their normal visual state (full opacity, reflecting their individual
true/falsesettings).* Ensure that Auto-Approve checkbox is not interactive when no action buttons are selected for auto approval
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
docs/settings.mdfile should be updated to include the new "Auto-approve API request count limit" setting.)Additional Notes
Greatly simplfied scope
Get in Touch