Skip to content

Conversation

@shariqriazz
Copy link
Contributor

@shariqriazz shariqriazz commented Jun 5, 2025

… and UI, identical to 05-06

Related GitHub Issue

Closes: #

Description

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Add gemini-2.5-pro-preview-06-05 model to Gemini and Vertex providers and update UI accordingly.

  • Models:
    • Add gemini-2.5-pro-preview-06-05 to geminiModels in gemini.ts.
    • Add gemini-2.5-pro-preview-06-05 to vertexModels in vertex.ts.
  • UI:
    • Update ModelInfoView in ModelInfoView.tsx to include gemini-2.5-pro-preview-06-05 in billing estimate logic.

This description was created by Ellipsis for 6a9f606. You can customize this summary. It will automatically update as commits are pushed.

@shariqriazz shariqriazz requested review from cte and mrubens as code owners June 5, 2025 15:56
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 5, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 5, 2025
@cryptobench
Copy link

cryptobench commented Jun 5, 2025

@shariqriazz Does this support the new thinking budget that the pro model just received similar to what the latest flash model has?

image

Edit I see in the code the other flash models have the key maxThinkingTokens: 24_576, , which this pro 05-06 doesn't have.

Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 5, 2025
@mrubens
Copy link
Collaborator

mrubens commented Jun 5, 2025

Should we add the thinking tokens before merging?

@daniel-lxs
Copy link
Member

@mrubens
You mean the thinking budget?

@daniel-lxs daniel-lxs moved this from PR [Needs Review] to PR [Changes Requested] in Roo Code Roadmap Jun 5, 2025
@daniel-lxs daniel-lxs moved this from PR [Changes Requested] to PR [Needs Prelim Review] in Roo Code Roadmap Jun 5, 2025
@mrubens
Copy link
Collaborator

mrubens commented Jun 5, 2025

Yeah let's just do the same thing as what we do with the other Gemini thinking models for now (a separate :thinking) version

@shariqriazz
Copy link
Contributor Author

Yeah let's just do the same thing as what we do with the other Gemini thinking models for now (a separate :thinking) version

But this model does not offer non thinking variant

@daniel-lxs daniel-lxs closed this Jun 5, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Jun 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 5, 2025
@shariqriazz shariqriazz deleted the add-gemini-pro-06-05 branch June 21, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants