Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Jun 6, 2025

Description

Encountered by both @mrubens and @hannesrudolph.


Important

Adds subprocess timeout handling in runTask.ts to prevent hanging processes and ensure container cleanup.

  • Error Handling:
    • Introduces SubprocessTimeoutError class in runTask.ts to handle subprocess timeouts.
  • Subprocess Management:
    • Modifies runTask function in runTask.ts to wait for subprocess completion with a 10-second timeout.
    • If subprocess exceeds timeout, logs error and attempts to kill subprocess with SIGKILL.
  • Client Disconnection:
    • Logs error if client disconnects before task completion in runTask.ts.

This description was created by Ellipsis for 6b1d839. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners June 6, 2025 21:13
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2025
@cte cte merged commit 6a232a9 into main Jun 7, 2025
7 of 8 checks passed
@cte cte deleted the cte/subprocess-hanging branch June 7, 2025 00:07
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants