Add execution marker for command execution tracking #4564
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4200
Closes: #4384
This PR implements a marker to track when a command finished executing as a workaround for this VSCode issue: microsoft/vscode#250764.
The inspiration comes from @sstublic's comment: #4200 (comment)
Basically commands executed by Roo Code will look like this on the terminal:
Then we check if the marker is present in the output, this is completely hidden from the model to avoid confusion.
I tested against the integrations tests that were failing due to the bug and it solved the issues.
Also tested on Windows.
Important
Adds execution marker in
TerminalProcessto track command completion by appending and detecting a unique marker in command output.executionMarkertoTerminalProcessto track command completion.run()to detect completion in output stream.fullOutputonce detected.shell_execution_completeevent with success exit code if marker is detected.run()to handle marker logic and stream processing.This description was created by
for 7b8dde8. You can customize this summary. It will automatically update as commits are pushed.