♻️ Refactor: Avoid type system duplication

[EamonNerbonne]

Description

Reduce duplication between compile-time types and run-time types. The aim is to reduce the amount of busywork when changing in particular settings state, without loss of compile-time type safety. This originates from Kilo-Org/kilocode#710 (where I work), but I hope it'll be useful for you too?

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).

I think an example speaks more clearly than type-system mumbo jumbo, so I decided to propose this with this example. If that's really unwanted - no hard feelings for closing the PR.

• Self-Review: I have performed a thorough self-review of my code.
• Code Quality:
  • ? My code adheres to the project's style guidelines.
  • There are no new linting errors or warnings (npm run lint).
  • All debug code (e.g., console.log) has been removed.
• Testing:
  • n/a New and/or updated tests have been added to cover my changes.
  • All tests pass locally (npm test).
  • The application builds successfully with my changes.
• Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
• n/a Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• n/a Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

---

main:

this branch:

---

main:

this branch:

---

One impact to be aware of is that the ordering of the string arrays now follows those of the zod types, and is thus no longer manual. I don't believe that's relevant, but perhaps I'm missing some subtlety.

---

Important

Refactor to reduce type duplication by using zod schema key extraction in global-settings.ts and provider-settings.ts.

• Refactor:
  • Remove keysOf function from type-fu.ts.
  • Replace manual key arrays with zod schema key extraction in global-settings.ts and provider-settings.ts.
• Behavior:
  • GLOBAL_SETTINGS_KEYS and PROVIDER_SETTINGS_KEYS now use zod schema key extraction.
  • SECRET_STATE_KEYS is now a constant array with type assertion.
• Misc:
  • Ordering of string arrays now follows zod types, not manual.

^{This description was created by for ba44e63. You can customize this summary. It will automatically update as commits are pushed.}

[hassoncs]

If we can do this and still get the same level of compile-time typing, I feel like there's no downside?

[EamonNerbonne]

Yes, this should have the same can't-miss-anything compile-time typing safety guarrantees. Apart from the ordering, it's I think equivalent.

[hannesrudolph]

@EamonNerbonne do you have discord?

[EamonNerbonne]

yeah; I replied in discord for convenience.

[hannesrudolph]

@EamonNerbonne I am sorry I am not sure which person you are. Can you DM me (hrudolph)?