Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 13, 2025

Reverts #4481

This seems to have removed the "enable reasoning" box for OpenRouter.


Important

Reverts reasoning budget support in Bedrock models, removing related logic, tests, and UI components.

  • Behavior:
    • Reverts addition of supportsReasoningBudget in bedrockModels in bedrock.ts.
    • Removes logic for handling reasoning budget in AwsBedrockHandler in bedrock.ts.
    • Deletes bedrock-reasoning.test.ts which tested reasoning budget functionality.
  • UI Changes:
    • Removes ThinkingBudget component usage in ApiOptions.tsx and Bedrock.tsx.
    • Adjusts ThinkingBudget.tsx to remove reasoning budget slider logic.
  • Misc:
    • Removes error handling related to reasoning budget in bedrock.ts.

This description was created by Ellipsis for f6149b5. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 13, 2025 05:40
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 13, 2025
@mrubens mrubens merged commit 47e84b4 into main Jun 13, 2025
14 of 15 checks passed
@mrubens mrubens deleted the revert-4481-4201-fix branch June 13, 2025 05:43
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 13, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 13, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants